karmada-io
JSON logging for namespace sync controller
What type of PR is this?
JSON logging support. More details are highlighted in https://github.com/karmada-io/karmada/issues/6230.
Which issue(s) this PR fixes: Fixes # Partof https://github.com/karmada-io/karmada/issues/6230
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign charlesqq for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @Bhaumik10! It looks like this is your first PR to karmada-io/karmada 🎉
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.
Project coverage is 49.04%. Comparing base (
c7d4705) to head (c1fc302).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...controllers/namespace/namespace_sync_controller.go | 25.00% | 11 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #6445 +/- ##
==========================================
+ Coverage 49.03% 49.04% +0.01%
==========================================
Files 687 687
Lines 56031 56037 +6
==========================================
+ Hits 27473 27484 +11
+ Misses 26776 26773 -3
+ Partials 1782 1780 -2
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 49.04% <25.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@Bhaumik10: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Bhaumik10 , thanks for this work. For now, we're going to refrain from using the controller runtime logging adaptor to keep the scope of the parent task more constrained. As such, we'll continue using the klog logging funcs directly in the controllers. Please take a look at this PR, which is already merged, and make changes accordingly for this one. Thanks!
closing this PR as open another one https://github.com/karmada-io/karmada/pull/6482