Update types.go

[LavredisG]

/kind documentation

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.28%. Comparing base (079d0ab) to head (6d2ae6b). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5691      +/-   ##
==========================================
- Coverage   46.31%   46.28%   -0.04%     
==========================================
  Files         661      661              
  Lines       54364    54364              
==========================================
- Hits        25177    25160      -17     
- Misses      27562    27575      +13     
- Partials     1625     1629       +4     

Flag	Coverage Δ
unittests	46.28% <ø> (-0.04%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[LavredisG]

/lgtm

Thanks @LavredisG for doing this. It looks great!

But there is another file which has almost the same content that needs to be fixed, would you like the fix them as well?

By the way, if you touch the file linked above, you have to generate the file by following command:

make update

Once I find some time I will probably fix the other one too. Could you please explain a bit more about the "make update" command? I do these changes from github gui, but in order to change the linked file I should first fork the repo and work on it locally in order to then execute the command?

[RainbowMango]

Could you please explain a bit more about the "make update" command?

This is a Makefile command and it will run some scripts to generates other files.

I do these changes from github gui, but in order to change the linked file I should first fork the repo and work on it locally in order to then execute the command?

Yes, I think so. You need to fork it on your local machine and run the command above. But don't worry, if you can't do that, I can help with the rest.

[LavredisG]

Could you please explain a bit more about the "make update" command?

This is a Makefile command and it will run some scripts to generates other files.

I do these changes from github gui, but in order to change the linked file I should first fork the repo and work on it locally in order to then execute the command?

Yes, I think so. You need to fork it on your local machine and run the command above. But don't worry, if you can't do that, I can help with the rest.

After running the make update command I got many "unused parameter" warnings on zz_generated.openapi.go and many "APU Rule violation" while the command was running, is that expected?

[RainbowMango]

After running the make update command I got many "unused parameter" warnings on zz_generated.openapi.go and many "APU Rule violation" while the command was running, is that expected?

I don't find any unused parameter warnings on my side, but the API Rule violation warning can be ignored(I don't know why honestly, but the result is good).

As long as it ends without errors, it should be OK. Just reminder to commit all generated files. I can see that one file(api/openapi-spec/swagger.json) is missing from this PR so far, everything else looks good.

[RainbowMango]

Hi @LavredisG Please feel free to let me know if you need any help. I can help to edit this PR if you want.

[LavredisG]

After running the make update command I got many "unused parameter" warnings on zz_generated.openapi.go and many "APU Rule violation" while the command was running, is that expected?

I don't find any unused parameter warnings on my side, but the API Rule violation warning can be ignored(I don't know why honestly, but the result is good).

As long as it ends without errors, it should be OK. Just reminder to commit all generated files. I can see that one file(api/openapi-spec/swagger.json) is missing from this PR so far, everything else looks good.

swagger.json didn't appear as changed file when I executed "git status". If you think that it should have changed, could you check it please?

One test failed with this:

[RainbowMango]

I can try to fix the swagger issue.

[RainbowMango]

Force pushed, didn't change anything but rebase the code. Let's see if we can make CI happy this time. /lgtm for the content

[RainbowMango]

Force pushed again, updated the swagger as per hack/update-codegen.sh.

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [RainbowMango]
• ~~pkg/apis/OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[RainbowMango]

/retest The failing test is unrelated and is tracked by #5855.