karmada icon indicating copy to clipboard operation
karmada copied to clipboard

operator/pkg/util/apiclient: unit test idempotence property

Open mohamedawnallah opened this issue 1 year ago • 3 comments

Description

In this commit, we unit test the idempotency property in API client operator package on Secrets, Services, Deployments, Mutating Webhook Configuration, Validating Webhook Configuration, API Service, Custom Resource Definitions, StatefulSet, ClusterRole, and ClusterRoleBinding.

What type of PR is this?

Which issue(s) this PR fixes: Part of #5491. Depends on #5602.

Does this PR introduce a user-facing change?:

NONE

mohamedawnallah avatar Oct 08 '24 18:10 mohamedawnallah

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 17 '24 16:10 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.77%. Comparing base (0d55ead) to head (6bd431e).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5654      +/-   ##
==========================================
- Coverage   39.09%   38.77%   -0.32%     
==========================================
  Files         650      650              
  Lines       45209    55125    +9916     
==========================================
+ Hits        17676    21377    +3701     
- Misses      26180    32374    +6194     
- Partials     1353     1374      +21     
Flag Coverage Δ
unittests 38.77% <100.00%> (-0.32%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 17 '24 16:10 codecov-commenter

cc @XiShanYongYe-Chang All test cases passed after rebasing on the master branch :)

mohamedawnallah avatar Oct 17 '24 19:10 mohamedawnallah