karmada icon indicating copy to clipboard operation
karmada copied to clipboard

operator/pkg/tasks: unit test components

Open mohamedawnallah opened this issue 1 year ago • 3 comments

Description

In this commit, we unit test the components in the karmada operator package.

What type of PR is this?

Which issue(s) this PR fixes: Part of #5491.

Dependency This PR depends on #5630.

Does this PR introduce a user-facing change?:

NONE

mohamedawnallah avatar Oct 01 '24 19:10 mohamedawnallah

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 01 '24 19:10 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.45%. Comparing base (19b32a2) to head (773761b). Report is 8 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5632      +/-   ##
==========================================
+ Coverage   39.02%   39.45%   +0.43%     
==========================================
  Files         650      650              
  Lines       45207    45207              
==========================================
+ Hits        17641    17837     +196     
+ Misses      26207    25995     -212     
- Partials     1359     1375      +16     
Flag Coverage Δ
unittests 39.45% <ø> (+0.43%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 17 '24 07:10 codecov-commenter

cc @XiShanYongYe-Chang All test cases passed after rebasing on the master branch :)

mohamedawnallah avatar Oct 17 '24 16:10 mohamedawnallah