karmada icon indicating copy to clipboard operation
karmada copied to clipboard

minimize the rbac permissions for karmada-agent

Open B1F030 opened this issue 1 year ago • 5 comments

What type of PR is this? /kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes: Part of #5182

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

B1F030 avatar Sep 30 '24 07:09 B1F030

/cc @zhzhuang-zju

B1F030 avatar Sep 30 '24 07:09 B1F030

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.85%. Comparing base (90df54a) to head (976e62f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5629      +/-   ##
==========================================
- Coverage   41.85%   41.85%   -0.01%     
==========================================
  Files         655      655              
  Lines       55756    55756              
==========================================
- Hits        23338    23335       -3     
- Misses      30907    30910       +3     
  Partials     1511     1511              
Flag Coverage Δ
unittests 41.85% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 30 '24 07:09 codecov-commenter

/hold

B1F030 avatar Sep 30 '24 07:09 B1F030

/unhold

B1F030 avatar Oct 29 '24 03:10 B1F030

/cc @zhzhuang-zju

B1F030 avatar Oct 29 '24 03:10 B1F030

Hi @B1F030 Please quash commits and get this PR ready.

RainbowMango avatar Oct 29 '24 06:10 RainbowMango

@B1F030 The review is ongoing, and I will check whether your RBAC configuration ensures the normal operation of the agent and whether there are any redundant permissions.

zhzhuang-zju avatar Oct 29 '24 06:10 zhzhuang-zju

cc @RainbowMango

zhzhuang-zju avatar Oct 29 '24 08:10 zhzhuang-zju

?

RainbowMango avatar Oct 29 '24 08:10 RainbowMango

thanks~ /lgtm cc @RainbowMango @XiShanYongYe-Chang

zhzhuang-zju avatar Oct 29 '24 11:10 zhzhuang-zju

/lgtm

XiShanYongYe-Chang avatar Oct 30 '24 01:10 XiShanYongYe-Chang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 30 '24 03:10 karmada-bot