karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[WIP] add realted ut for migration rollback feature

Open wulemao opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add realted ut for migration rollback feature

Which issue(s) this PR fixes:

Fixes part of #5380

Special notes for your reviewer:

!!!need rebasing upon #5626, waiting for it to be merged

Does this PR introduce a user-facing change?:


wulemao avatar Sep 30 '24 04:09 wulemao

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.85%. Comparing base (6c6281f) to head (83a23ab).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5628      +/-   ##
==========================================
+ Coverage   41.63%   41.85%   +0.22%     
==========================================
  Files         655      655              
  Lines       55753    55756       +3     
==========================================
+ Hits        23211    23337     +126     
+ Misses      31036    30908     -128     
- Partials     1506     1511       +5     
Flag Coverage Δ
unittests 41.85% <100.00%> (+0.22%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 30 '24 04:09 codecov-commenter

Hi @wulemao Please rebase as #5626 has been merged.

RainbowMango avatar Oct 29 '24 01:10 RainbowMango

cc @chaosi-zju

wulemao avatar Oct 29 '24 09:10 wulemao

/lgtm

/cc @XiShanYongYe-Chang

chaosi-zju avatar Oct 29 '24 12:10 chaosi-zju

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 29 '24 12:10 karmada-bot