support unregister cluster in karmada
What type of PR is this?
/kind feature
What this PR does / why we need it:
support unregister cluster in karmada
Which issue(s) this PR fixes:
Fixes part of #5380
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
karmadactl: support unregister a pull mode cluster
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0.39526% with 252 lines in your changes missing coverage. Please review.
Project coverage is 41.50%. Comparing base (
e204459) to head (f803efe). Report is 18 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5626 +/- ##
==========================================
+ Coverage 40.85% 41.50% +0.64%
==========================================
Files 651 655 +4
Lines 55259 55741 +482
==========================================
+ Hits 22577 23136 +559
+ Misses 31240 31105 -135
- Partials 1442 1500 +58
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 41.50% <0.39%> (+0.64%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
latest test report:
According to what we communicated offline, pr is updated
@chaosi-zju ready to review
/lgtm
/cc @zhzhuang-zju @RainbowMango help a look
@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: a, look.
Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/lgtm
/cc @zhzhuang-zju @RainbowMango help a look
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
updated, latest test result:
is there any more comments?
updated, thank you for checking again.
thanks~ others LGTM
comments fixed, any more comments? @RainbowMango
https://github.com/karmada-io/karmada/blob/2a4567cbcc9a305baf977ba66133b9c55108347b/pkg/controllers/certificate/cert_rotation_controller.go#L52-L60
@wulemao @chaosi-zju
CertRotationController in karmad-agent will look up and update the secret karmada-kubeconfig, which has been renamed to karmada-agent-config. We can use func getKarmadaAgentConfig to optimize this hard-coded section.
updated, latest test result:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment