karmada icon indicating copy to clipboard operation
karmada copied to clipboard

support preserving resource in member cluster when executing `karmadactl unjoin`

Open wulemao opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR aims to add support for preserving resources in the member cluster when executing karmadactl unjoin. This enhancement allows users to choose whether to preserve member cluster resources during the unjoin command.

Which issue(s) this PR fixes:

Fixes part of #5380

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmadactl: support preserving resource in member cluster when executing `karmadactl unjoin`

wulemao avatar Sep 23 '24 12:09 wulemao

Welcome @wulemao! It looks like this is your first PR to karmada-io/karmada 🎉

karmada-bot avatar Sep 23 '24 12:09 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.58%. Comparing base (07c6cb4) to head (e0017b6).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5594   +/-   ##
=======================================
  Coverage   41.58%   41.58%           
=======================================
  Files         655      655           
  Lines       55753    55753           
=======================================
  Hits        23186    23186           
  Misses      31062    31062           
  Partials     1505     1505           
Flag Coverage Δ
unittests 41.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 23 '24 13:09 codecov-commenter

/lgtm

chaosi-zju avatar Oct 29 '24 07:10 chaosi-zju

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 29 '24 07:10 karmada-bot

/retest

chaosi-zju avatar Oct 29 '24 08:10 chaosi-zju