karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[Umbrella] Defining resource deleteion policy to support migration rollback

Open XiShanYongYe-Chang opened this issue 1 year ago • 7 comments

What would you like to be added:

Provides the ability to roll back migration safely.

Why is this needed:

For specific details, please refer to #5101.

The specific work items can be planned as follows:

  • [x] New proposal @CharlesQQ @XiShanYongYe-Chang #5101
  • [x] Proposing API to support migration rollback @RainbowMango #5575
  • [x] Function Implementation @a7i #5597
  • [ ] Refactor: optimize the processing of labels and annotations during resource depletion @a7i
  • [ ] Rollback the migration of dependency distributed resources @XiShanYongYe-Chang #5717
  • [ ] karmadactl promote can help rollout safely @wulemao
  • [ ] Test Coverage
    • [x] UT @a7i #5597
    • [ ] E2E @wulemao
  • [ ] Document Description

XiShanYongYe-Chang avatar Sep 21 '24 02:09 XiShanYongYe-Chang

Hi @a7i would you like to contribute this feature? cc @a7i

XiShanYongYe-Chang avatar Sep 21 '24 02:09 XiShanYongYe-Chang

/kind feature

XiShanYongYe-Chang avatar Sep 21 '24 02:09 XiShanYongYe-Chang

Hi @a7i would you like to contribute this feature? cc @a7i

Yes absolutely! 🎉

a7i avatar Sep 21 '24 12:09 a7i

Hi, everybody, I am working on #5380 tasks, which is highly relevant to this issue.

I am interested in this issue too, could you please assign some related test job to me?

wulemao avatar Sep 23 '24 12:09 wulemao

Hi @a7i, how about handing over E2E tasks to @wulemao?

XiShanYongYe-Chang avatar Sep 23 '24 13:09 XiShanYongYe-Chang

I added one more task, which we should let karmadactl promote leverage this feature to guarantee the promotion can be rolled back safely. To address the issue #3004 sent by @chaunceyjiang .

RainbowMango avatar Sep 25 '24 03:09 RainbowMango

I added one more task, which we should let karmadactl promote leverage this feature to guarantee the promotion can be rolled back safely. To address the issue #3004 sent by @chaunceyjiang .

It is also a very interesting optimization. could I assign for it?

wulemao avatar Sep 25 '24 06:09 wulemao

@XiShanYongYe-Chang website pr all merged

chaosi-zju avatar Oct 29 '24 08:10 chaosi-zju

Thanks all~ /close

XiShanYongYe-Chang avatar Oct 29 '24 09:10 XiShanYongYe-Chang

@XiShanYongYe-Chang: Closing this issue.

In response to this:

Thanks all~ /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Oct 29 '24 09:10 karmada-bot