karmada icon indicating copy to clipboard operation
karmada copied to clipboard

test/e2e/karmadactl_test.go: test init command

Open mohamedawnallah opened this issue 1 year ago • 3 comments

Description:

In this commit, we test karmadactl init command on creating karmada control plane on a brand new created cluster with default params and verifying all karmada system components are up and running.

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #4544

Does this PR introduce a user-facing change?:

NONE

mohamedawnallah avatar Aug 28 '24 13:08 mohamedawnallah

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 28 '24 13:08 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.43%. Comparing base (2f6ff56) to head (9d2ad25). Report is 5 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5446      +/-   ##
==========================================
+ Coverage   48.27%   48.43%   +0.16%     
==========================================
  Files         677      677              
  Lines       56067    56067              
==========================================
+ Hits        27068    27158      +90     
+ Misses      27229    27128     -101     
- Partials     1770     1781      +11     
Flag Coverage Δ
unittests 48.43% <ø> (+0.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Aug 28 '24 13:08 codecov-commenter

~~It looks like there's an issue with the karmada-scheduler pod, as it encounters a CrashLoopBackOff error. This problem arises with the karmada-scheduler pod in the latest Karmada release (v1.10.4), and the error reported is unknown flag: --scheduler-estimator-ca-file. It seems that this flag was either not introduced or was removed in release v1.10.4?~~

~~Here are the relevant details:~~

~~Current Pod Status~~

kubectl get all -n karmada-system --context kind-member-e2e-lpcsb --kubeconfig ~/.kube/member-e2e-lpcsb.config
NAME                                                READY   STATUS             RESTARTS      AGE
pod/etcd-0                                          1/1     Running            0             2m5s
pod/karmada-aggregated-apiserver-5fb8fc5c8f-mgwfr   1/1     Running            0             87s
pod/karmada-apiserver-6b9b685766-nnqcq              1/1     Running            0             118s
pod/karmada-scheduler-56cc67c4f7-q6cjn              0/1     CrashLoopBackOff   3 (31s ago)   74s
pod/kube-controller-manager-5bb56789df-gsp6s        1/1     Running            0             77s

NAME                                   TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)             AGE
service/etcd                           ClusterIP   None           <none>        2379/TCP,2380/TCP   2m5s
service/karmada-aggregated-apiserver   ClusterIP   10.96.82.139   <none>        443/TCP             87s
service/karmada-apiserver              NodePort    10.96.122.39   <none>        5443:32443/TCP      118s
service/kube-controller-manager        ClusterIP   10.96.149.67   <none>        10257/TCP           77s

NAME                                           READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/karmada-aggregated-apiserver   1/1     1            1           87s
deployment.apps/karmada-apiserver              1/1     1            1           118s
deployment.apps/karmada-scheduler              0/1     1            0           74s
deployment.apps/kube-controller-manager        1/1     1            1           77s

NAME                                                      DESIRED   CURRENT   READY   AGE
replicaset.apps/karmada-aggregated-apiserver-5fb8fc5c8f   1         1         1       87s
replicaset.apps/karmada-apiserver-6b9b685766              1         1         1       118s
replicaset.apps/karmada-scheduler-56cc67c4f7              1         1         0       74s
replicaset.apps/kube-controller-manager-5bb56789df        1         1         1       77s

NAME                    READY   AGE
statefulset.apps/etcd   1/1     2m5s

~~Error Details~~

kubectl logs pod/karmada-scheduler-56cc67c4f7-q6cjn -n karmada-system --context kind-member-e2e-lpcsb --kubeconfig ~/.kube/member-e2e-lpcsb.config
Usage:
  karmada-scheduler [flags]

Available Commands:
  karmada-scheduler completion                      Generate the autocompletion script for the specified shell
  karmada-scheduler help                            Help about any command
  karmada-scheduler version                         Print the version information

Generic flags:
...
      --scheduler-estimator-ca-file string         The CA file for the scheduler estimator service. (not available in v1.10.4)
...

Error: unknown flag: --scheduler-estimator-ca-file

mohamedawnallah avatar Aug 28 '24 13:08 mohamedawnallah

After rebasing on the master branch, I'm no longer able to reproduce the issue I previously reported. I'll ask for review when the CI tests are complete :)

mohamedawnallah avatar Apr 22 '25 06:04 mohamedawnallah

I think this PR is now ready for review :)

cc: @XiShanYongYe-Chang, @zhzhuang-zju

mohamedawnallah avatar Apr 23 '25 01:04 mohamedawnallah

Thanks, I think it is okay now. Can you help squash the commits? Ask @zhzhuang-zju to help take a look. /cc @zhzhuang-zju

XiShanYongYe-Chang avatar Apr 25 '25 03:04 XiShanYongYe-Chang