karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[Summer OSPP 2024] karmadactl init supports configuration file

Open liangyuanpeng opened this issue 1 year ago • 2 comments

What would you like to be added

As the community grows, karmada has more and more components and the configuration required is becoming more and more complex. Karmada hopes to transfer configuration items to the configuration file instead of more and more flags.

At the same time, it is hoped that a function that can list all container images used in the karmadactl init process can be implemented.

Releated:

  • https://github.com/karmada-io/karmada/issues/3464
  • https://github.com/karmada-io/karmada/issues/4086

This is part of https://github.com/karmada-io/karmada/issues/4879

Project link

https://summer-ospp.ac.cn/org/prodetail/245c40186?lang=zh&list=pro

Desired outcomes

  • [x] proposal https://github.com/karmada-io/karmada/pull/5277
  • [ ] implement the feature for karmadactl config images list https://github.com/karmada-io/karmada/pull/5306
  • [ ] implement the feature for karmadactl init with configuration file https://github.com/karmada-io/karmada/pull/5357
  • [ ] tests
  • [ ] blog/doc for the feature https://github.com/karmada-io/website/pull/690
  • [x] sub task https://github.com/karmada-io/karmada/pull/5321

liangyuanpeng avatar Aug 16 '24 07:08 liangyuanpeng

/assign

tiansuo114 avatar Aug 17 '24 10:08 tiansuo114

https://github.com/karmada-io/website/pull/690

Here is the documentation for karmadactl changes Supplement pr @liangyuanpeng

tiansuo114 avatar Sep 21 '24 14:09 tiansuo114

@tiansuo114 Congrats! All tasks have been done. Thank you for your hard work!

/close

RainbowMango avatar Oct 29 '24 06:10 RainbowMango

@RainbowMango: Closing this issue.

In response to this:

@tiansuo114 Congrats! All tasks have been done. Thank you for your hard work!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Oct 29 '24 06:10 karmada-bot

What would you like to be added

As the community grows, karmada has more and more components and the configuration required is becoming more and more complex. Karmada hopes to transfer configuration items to the configuration file instead of more and more flags.

At the same time, it is hoped that a function that can list all container images used in the karmadactl init process can be implemented.

Releated:

This is part of #4879

Project link

https://summer-ospp.ac.cn/org/prodetail/245c40186?lang=zh&list=pro

Desired outcomes

The PR related to tests has been changed to the PR at https://github.com/karmada-io/karmada/pull/5306. Should we update the documentation to reflect this? @liangyuanpeng

tiansuo114 avatar Oct 29 '24 07:10 tiansuo114

The PR related to tests has been changed to the PR at https://github.com/karmada-io/karmada/pull/5306. Should we update the documentation to reflect this? @liangyuanpeng

sure, i updated it, thank you!

liangyuanpeng avatar Oct 30 '24 05:10 liangyuanpeng

The PR related to tests has been changed to the PR at #5306. Should we update the documentation to reflect this? @liangyuanpeng

sure, i updated it, thank you!

Thank you very much, Mentor, for your guidance over the past few months in completing the OSPP tasks. I am truly grateful for all the help you've provided, and I hope to receive even more guidance from you in future PRs

tiansuo114 avatar Oct 30 '24 06:10 tiansuo114