karmada-io
Added karmadactl command line tool feature :karmadactl config image list
What type of PR is this? /kind feature
What this PR does / why we need it: Support command of karmadactl config images list
user@virtual-machine:karmada#make karmadactl
BUILD_PLATFORMS=linux/amd64 hack/build.sh karmadactl
!!! Building karmadactl for linux/amd64:
+ CGO_ENABLED=0
+ GOOS=linux
+ GOARCH=amd64
+ go build -ldflags '-X github.com/karmada-io/karmada/pkg/version.gitVersion=v1.11.0 -X github.com/karmada-io/karmada/pkg/version.gitCommit=... - -o _output/bin/linux/amd64/karmadactl github.com/karmada-io/karmada/cmd/karmadactl
+ set +x
user@virtual-machine:karmada/_output/bin/linux/amd64#/karmadactl config image list
registry.k8s.io/kube-apiserver:v1.29.6
registry.k8s.io/kube-controller-manager:v1.29.6
registry.k8s.io/etcd:3.5.13-0
docker.io/alpine:3.19.1
docker.io/karmada/karmada-scheduler:v1.11.0
docker.io/karmada/karmada-controller-manager:v1.11.0
docker.io/karmada/karmada-webhook:v1.11.0
docker.io/karmada/karmada-aggregated-apiserver:v1.11.0
Which issue(s) this PR fixes: Fixes #4086 This PR is related to the documentation PR: https://github.com/karmada-io/karmada/pull/5277 Special notes for your reviewer: @liangyuanpeng Does this PR introduce a user-facing change?:
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 41.67%. Comparing base (
9754a28) to head (4ceb01d). Report is 8 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5306 +/- ##
==========================================
+ Coverage 41.64% 41.67% +0.02%
==========================================
Files 653 653
Lines 55484 55518 +34
==========================================
+ Hits 23109 23135 +26
- Misses 30876 30883 +7
- Partials 1499 1500 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 41.67% <ø> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
May need help😭😭, in my own project's github action, these tests passed correctly, but when I commit, these tests become failed, what should I do to fix these problems @liangyuanpeng
Thanks you working for it, could you please add some e2e test here? Maybe take a look at how kubeadm does it.感谢您的工作，您可以在此处添加一些 e2e 测试吗？也许看看 kubeadm 是如何做到的。
I have fixed the issues you pointed out and provided new e2e test cases. Please let me know if there are any further modifications needed. :)
This PR is related to the documentation PR: https://github.com/karmada-io/karmada/pull/5277
@tiansuo114
Add to PR issue body would be great, thank you!
This PR is related to the documentation PR: #5277此 PR 与文档 PR 相关： #5277
@tiansuo114
Add to PR issue body would be great, thank you!添加到 PR 问题正文会很棒，谢谢！
Ok, I modified the pr and the other two questions about pr and added links to it
/hold /抓住 need squash the commits when ready to merge.准备合并时需要压缩提交。
Ok, I will squash commit after the problem in comment is solved
@zhzhuang-zju anyelse comment here?
Can this pr be merged now or does it need to be further modified😭😭
The command in this feature PR has been modified to match the current documentation format, but its functionality remains unchanged and is still the same as it was initially. @liangyuanpeng @RainbowMango
Based on community meetings, it seems that this feature is not necessary and will increase maintenance costs, so this pr is temporarily closed
https://github.com/karmada-io/karmada/pull/5744 is migration to here (for Summer OSPP 2024)
Based on the OSPP project's requirements, this PR has been reopened. However, the relevant content in this PR has been changed to add automated testing for the new karmadactl init --config command as indicated in the link.
@liangyuanpeng @RainbowMango @zhzhuang-zju
#5744 is migration to here (for Summer OSPP 2024)
The code in this PR has been re-pushed and tested, and after a code clean-up, I’ve removed the unnecessary metadata part in KarmadaInitConfig. We can now continue with the previous review.🎉
If need to track this issue, please refer to the relevant changes in this PR. @RainbowMango @liangyuanpeng
@liangyuanpeng: GitHub didn't allow me to request PR reviews from the following users: want, to, review, for, if, you.
Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
thank you! /lgtm /cc @zhzhuang-zju if you want to review for karmadactl
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
It seems this is the last PR for the summer OSPP program. #5387. Please let me know if I miss anything.
It seems this is the last PR for the summer OSPP program. #5387. Please let me know if I miss anything.
Yes, this PR is the last one for the OSPP tasks. Up until now, with the merge of this PR into the main branch, all planned PRs have been incorporated into Karmada. PR Link 1: https://github.com/karmada-io/karmada/pull/5277 PR Link 2: https://github.com/karmada-io/karmada/pull/5306 PR Link 3: https://github.com/karmada-io/karmada/pull/5357 PR Link 4: https://github.com/karmada-io/website/pull/690 PR Link 5: https://github.com/karmada-io/karmada/pull/5321
It seems this is the last PR for the summer OSPP program. https://github.com/karmada-io/karmada/issues/5387.
Yes, it is. /lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liangyuanpeng, RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~.github/workflows/OWNERS~~ [RainbowMango,liangyuanpeng]
- ~~hack/OWNERS~~ [RainbowMango,liangyuanpeng]
- ~~pkg/karmadactl/cmdinit/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment