karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Enhance karmadactl operation and maintenance experience

Open zhzhuang-zju opened this issue 1 year ago • 9 comments

What would you like to be added: Refer to https://github.com/karmada-io/karmada/issues/4291 and https://github.com/karmada-io/karmada/issues/5248, we have decided to continuously improve and enhance the user experience of karmadactl in upcoming releases. To track the progress of the project, we will divide it into the following subtasks:

  • [x] proposal: Analyzing and designing the flag sets and behavior of the commands. (@hulizhe #5245)

Implement new Commands

  • [x] karmadactl create (@hulizhe #5399 )
  • [x] karmadactl patch (@zhzhuang-zju #5463)
  • [x] karmadactl delete (@zhzhuang-zju #5431)
  • [x] karmadactl label (@zhzhuang-zju #5453)
  • [x] karmadactl annotate (@zhzhuang-zju #5458)
  • [x] karmadactl edit (@zhzhuang-zju #5434)
  • [x] karmadactl attach (@hulizhe #5395)
  • [x] karmadactl api-resources (@hulizhe #5394)
  • [x] karmadactl explain (@hulizhe #5393)
  • [ ] karmadactl port-forward (@zhzhuang-zju #5464)

Modification of Existing Commands:

  • [x] karmadactl get (@hulizhe #5254)
  • [x] karmadactl describe (@hulizhe #5392)
  • [x] karmadactl top pod (@hulizhe #5452)
  • [x] karmadactl exec(@hulizhe #5398)
  • [x] karamdactl top node (@zhzhuang-zju #4224)

Note:

  • The flag sets and command behavior need to be consistent with Proposal #5245.
  • If there are any other requirements or concerns regarding karmadactl, please feel free to discuss them.
  • The subtasks may undergo changes.

zhzhuang-zju avatar Jul 25 '24 09:07 zhzhuang-zju

/help

zhzhuang-zju avatar Jul 25 '24 09:07 zhzhuang-zju

@zhzhuang-zju: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Jul 25 '24 09:07 karmada-bot

cc @IonBoleac

zhzhuang-zju avatar Jul 25 '24 09:07 zhzhuang-zju

Hi @zhzhuang-zju Can I get a task that is easier in this issue?

Affan-7 avatar Jul 25 '24 09:07 Affan-7

Is there an explanation of every command that what they must do?

IonBoleac avatar Jul 25 '24 10:07 IonBoleac

Hi @zhzhuang-zju Can I get a task that is easier in this issue?

@Affan-7 Sure~you can take karmadactl patch first, Because this command only works on the Karmada control plane and does not involve switching member clusters, it is relatively easy to get started with

Is there an explanation of every command that what they must do?

you can refer to https://github.com/karmada-io/karmada/pull/5245, it contains the flag sets and behavior of the commands.

zhzhuang-zju avatar Jul 26 '24 01:07 zhzhuang-zju

all of PRs for the new command need the release-note ^^^ cc @hulizhe

liangyuanpeng avatar Aug 19 '24 03:08 liangyuanpeng

all of PRs for the new command need the release-note ^^^ cc @hulizhe

thanks for the reminder

hulizhe avatar Aug 19 '24 03:08 hulizhe

@IonBoleac @Affan-7 I hope to include the enhancements to karmadactl in the release 1.11.0, so I have completed the remaining work for this issue. However, this is just the first phase of enhancing karmadactl capabilities, and there will be further work to follow. I welcome your continued participation in the subsequent efforts, thanks~

zhzhuang-zju avatar Aug 30 '24 02:08 zhzhuang-zju

All tasks planed in this round are done. /close

RainbowMango avatar Aug 31 '24 03:08 RainbowMango

@RainbowMango: Closing this issue.

In response to this:

All tasks planed in this round are done. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Aug 31 '24 03:08 karmada-bot