karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[lfx-mentorship-2024-September-November] Enhance the test coverage for the Karmada search, operator, and webhook components.

Open XiShanYongYe-Chang opened this issue 1 year ago • 13 comments

CNCF LFX mentorship https://github.com/cncf/mentoring/blob/main/programs/lfx-mentorship/2024/03-Sep-Nov/README.md

Mentor: @XiShanYongYe-Chang

What would you like to be added:

Karmada would like to improve the UT coverage of the code to better maintain the quality of the code and reduce the introduction of defects.

Increase the UT coverage rate to 50% to 60% (currently, the UT coverage rate is 28.26% ).

The entire Karmada repository is a bit large for one project, so we will split it into two projects. The current project needs to improve UT coverage except for the following directory:

pkg/controllers
pkg/dependenciesdistributor
pkg/descheduler
pkg/detector
pkg/estimator
pkg/scheduler
pkg/resourceinterpreter
pkg/util

This, together with #5235, constitutes our enhanced UT task.

I hope that the students who apply for this project can give the UT coverage rate of each directory plan to achieve, we will move towards these specific goals.

Why is this needed:

XiShanYongYe-Chang avatar Jul 23 '24 08:07 XiShanYongYe-Chang

@XiShanYongYe-Chang Any pretest for this project and recommended communication channels to connect

varshith257 avatar Jul 26 '24 09:07 varshith257

Hi @varshith257 The project has not been reported. The progress will be synchronized to the current issue.

XiShanYongYe-Chang avatar Jul 26 '24 10:07 XiShanYongYe-Chang

Hi @XiShanYongYe-Chang I'm interested in this project under LFX Mentorship. I've submitted a PR to fully test federatedresourcequota webhook so I could get more familiar with these ones. I'd love to receive any feedback thanks! 🙏

mohamedawnallah avatar Aug 01 '24 03:08 mohamedawnallah

Thanks @mohamedawnallah /assign

XiShanYongYe-Chang avatar Aug 01 '24 03:08 XiShanYongYe-Chang

@XiShanYongYe-Chang Hey, great project! I'm interested in contributing to it. under LFX Mentorship I have experience in writing test cases and look forward to making valuable contributions. Looking forward to collaborating with you all!

yashpandey06 avatar Aug 01 '24 15:08 yashpandey06

We look forward to every enthusiastic partner to join the Karmada community. ^-^

/unassign

XiShanYongYe-Chang avatar Aug 02 '24 01:08 XiShanYongYe-Chang

@XiShanYongYe-Chang I completed the LFX tasks and looking for some pre-tests. I have experience in writing unit tests and made patches of implementing unit tests in Wikimedia foundation core project.

anujagrawal699 avatar Aug 04 '24 09:08 anujagrawal699

@XiShanYongYe-Chang Here it is.

anujagrawal699 avatar Aug 06 '24 10:08 anujagrawal699

Just for reference: We can get the code coverage of different files under the current master branch from here.

XiShanYongYe-Chang avatar Aug 07 '24 03:08 XiShanYongYe-Chang

Just for reference: We can get the code coverage of different files under the current master branch from here.

Really helped 😃

yashpandey06 avatar Aug 07 '24 03:08 yashpandey06

Hi @XiShanYongYe-Chang I am interested in this project. Currently working on multiclusteringress webhook so to get familiarity. Looking forward for contributions!

836hardik-agrawal avatar Aug 08 '24 05:08 836hardik-agrawal

Hello everyone, thank you all very much for your active contributions, the Karmada community warmly welcomes everyone to participate in open-source contributions. You can see that the number of our LFX project spots is less than the number of applicants, which means that the final number of selected participants will be quite small. However, I hope everyone can understand that this is not because you are not good enough. On the contrary, being able to actively participate in open-source contributions, you are all very excellent. Therefore, even if you are not selected for this LFX event in the end, please don't be disappointed. There will still be LFX events to apply for in the future, and I hope everyone can continue to participate and pay attention to the Karmada community.

XiShanYongYe-Chang avatar Aug 17 '24 03:08 XiShanYongYe-Chang

Hello everyone, thank you all very much for your active contributions, the Karmada community warmly welcomes everyone to participate in open-source contributions. You can see that the number of our LFX project spots is less than the number of applicants, which means that the final number of selected participants will be quite small. However, I hope everyone can understand that this is not because you are not good enough. On the contrary, being able to actively participate in open-source contributions, you are all very excellent. Therefore, even if you are not selected for this LFX event in the end, please don't be disappointed. There will still be LFX events to apply for in the future, and I hope everyone can continue to participate and pay attention to the Karmada community.

Fingers crossed 🤞..let's hope for good .

yashpandey06 avatar Aug 17 '24 10:08 yashpandey06

Hi @mohamedawnallah the lfx project is ready to start. Do you have time to make a detailed project plan for the project and submit an issue for task tracking?

XiShanYongYe-Chang avatar Sep 06 '24 01:09 XiShanYongYe-Chang

Best of luck fellows @anujagrawal699 @mohamedawnallah

yashpandey06 avatar Sep 06 '24 03:09 yashpandey06

Hi @XiShanYongYe-Chang, That is great! I would submit a tracking issue today for the project!

mohamedawnallah avatar Sep 06 '24 03:09 mohamedawnallah

This task will be tracked by #5491 Thanks all. /close

XiShanYongYe-Chang avatar Sep 09 '24 08:09 XiShanYongYe-Chang

@XiShanYongYe-Chang: Closing this issue.

In response to this:

This task will be tracked by #5491 Thanks all. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Sep 09 '24 08:09 karmada-bot