karmada-io
Define top level Permission for lint-chart.yaml (Chart Lint) workflow
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: Part of #5048
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
master@5e35497). Learn more about missing BASE report.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5081 +/- ##
=========================================
Coverage ? 28.22%
=========================================
Files ? 632
Lines ? 43551
Branches ? 0
=========================================
Hits ? 12292
Misses ? 30363
Partials ? 896
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 28.22% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@aditya7302 thanks for your work~ Due to the path limitation https://github.com/karmada-io/karmada/blob/1255a08f5d84c2ec6c947d612642b2c35538ab99/.github/workflows/lint-chart.yaml#L16-L18 in Chart Lint, you can test it on your repo by submitting a pr with modifation under the directory charts.
@zhzhuang-zju Here is the run of the Chart Lint workflow by making changes under the directory charts : https://github.com/aditya7302/karmada/actions/runs/9666757857/workflow