karmada
karmada copied to clipboard
Bump golangci-lint to v1.58.0
What type of PR is this? /kind cleanup
What this PR does / why we need it: Bump golangci-lint to v1.58.0. The following tasks are included:
- Update the
golangci-lint
version inhack/verify-staticcheck.sh
- The configuration option
run.skip-dirs
is deprecated, useissues.exclude-dirs
instead. - The configuration option
run.skip-dirs-use-default
is deprecated, useissues.exclude-dirs-use-default
instead. - Fix newly scanned errors
Which issue(s) this PR fixes: Fixes #4907
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
since this is the last task, so i think you can fix the issue with fixes #4907
Codecov Report
Attention: Patch coverage is 34.88372%
with 28 lines
in your changes are missing coverage. Please review.
Project coverage is 53.19%. Comparing base (
4ccffcc
) to head (309c677
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #4930 +/- ##
=======================================
Coverage 53.18% 53.19%
=======================================
Files 252 252
Lines 20510 20510
=======================================
+ Hits 10909 10911 +2
+ Misses 8882 8880 -2
Partials 719 719
Flag | Coverage Δ | |
---|---|---|
unittests | 53.19% <34.88%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment