karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Published 20 hours ago • verified publisher icon karmada-io

[Umbrella] Align generation and observedGeneration fields by reflectstatus and aggregatestatus operation

Open yike21 opened this issue 10 months ago • 15 comments

What would you like to be added: There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

  • Native resource
    • [ ] GroupVersion: apps/v1 Kind:
      • [x] Deployment @veophi #4867
      • [ ] DaemonSet @whitewindmills
      • [ ] StatefulSet @liangyuanpeng
  • Thirdparty resource
    • [ ] GroupVersion: apps.kruise.io/v1alpha1 Kind:
      • [ ] CloneSet @veophi #5057
      • [ ] DaemonSet
    • [ ] GroupVersion: apps.kruise.io/v1beta1 Kind:
      • [ ] StatefulSet @zhy76 #5094
    • [ ] GroupVersion: helm.toolkit.fluxcd.io/v2beta1 Kind:
      • [ ] HelmRelease @Akash-Singh04
    • [ ] GroupVersion: kustomize.toolkit.fluxcd.io/v1 Kind:
      • [ ] Kustomization @yike21 #5084
    • [ ] GroupVersion: source.toolkit.fluxcd.io/v1 Kind:
      • [ ] GitRepository @yike21 #5086
    • [ ] GroupVersion: source.toolkit.fluxcd.io/v1beta2 Kind:
      • [ ] Bucket
      • [ ] HelmChart
      • [ ] HelmRepository
      • [ ] OCIRepository

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

yike21 avatar Apr 25 '24 09:04 yike21

@yike21: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

What would you like to be added: There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

  • native resource
  • [ ] GroupVersion: apps/v1 kind:
    • [ ] Deployment @veophi #4867
    • [ ] DaemonSet
    • [ ] StatefulSet
  • Thirdparty resource
  • [ ] GroupVersion: apps.kruise.io/v1alpha1 kind:
    • [ ] CloneSet
    • [ ] DaemonSet
  • [ ] GroupVersion: apps.kruise.io/v1beta1 kind:
    • [ ] StatefulSet
  • [ ] GroupVersion: helm.toolkit.fluxcd.io/v2beta1 kind:
    • [ ] HelmRelease
  • [ ] GroupVersion: kustomize.toolkit.fluxcd.io/v1 kind:
    • [ ] Kustomization
  • [ ] GroupVersion: source.toolkit.fluxcd.io/v1 kind:
    • [ ] GitRepository
  • [ ] GroupVersion: source.toolkit.fluxcd.io/v1beta2 kind:
    • [ ] Bucket
    • [ ] HelmChart
    • [ ] HelmRepository
    • [ ] OCIRepository

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karmada-bot avatar Apr 25 '24 09:04 karmada-bot

I want to try it for StatefulSet

liangyuanpeng avatar Apr 25 '24 10:04 liangyuanpeng

I want to try it for StatefulSet

Thanks a lot~

yike21 avatar Apr 25 '24 10:04 yike21

@yike21 Good Job!

XiShanYongYe-Chang avatar Apr 25 '24 11:04 XiShanYongYe-Chang

I wanna pick up DaemonSet, thanks.

whitewindmills avatar Apr 26 '24 03:04 whitewindmills

I wanna pick up DaemonSet, thanks.

ok, thanks a lot~

yike21 avatar Apr 26 '24 04:04 yike21

I am also concerned about this question. What is the current progress of cloneset? I can get involved in this issue about other resource, too

zhy76 avatar May 30 '24 17:05 zhy76

It will continue to advance in the next version.

XiShanYongYe-Chang avatar May 31 '24 01:05 XiShanYongYe-Chang

Hello everyone, we can continue this issue. @veophi @yike21 @whitewindmills @liangyuanpeng

XiShanYongYe-Chang avatar Jun 17 '24 03:06 XiShanYongYe-Chang

Hey is this issue still open? if so, I would like to work on it

SkySingh04 avatar Jun 17 '24 16:06 SkySingh04

Hey is this issue still open? if so, I would like to work on it

Thanks! you can choose what you are interested in.

yike21 avatar Jun 18 '24 01:06 yike21

Can I work on apps.kruise.io/v1beta1 statefulset?

zhy76 avatar Jun 18 '24 05:06 zhy76

Can I work on apps.kruise.io/v1beta1 statefulset?

ok, thanks a lot~

yike21 avatar Jun 18 '24 05:06 yike21

Can we get started on this issue or should we wait for #5057 to be completed? I would like to work on helm.toolkit.fluxcd.io/v2beta1

SkySingh04 avatar Jun 22 '24 05:06 SkySingh04

Can we get started on this issue or should we wait for #5057 to be completed? I would like to work on helm.toolkit.fluxcd.io/v2beta1

Thanks, let's start this issue! We need to modify AggregateStatus and statusReflection, then update testdata to characterize the new customizations.

yike21 avatar Jun 22 '24 06:06 yike21

Hello everyone, we can continue this issue. @veophi @yike21 @whitewindmills @liangyuanpeng

I will open a PR for StatefulSet in this week.

liangyuanpeng avatar Jul 08 '24 10:07 liangyuanpeng

/reopen as closed by #5196 by mistake.

RainbowMango avatar Jul 19 '24 09:07 RainbowMango

@RainbowMango: Reopened this issue.

In response to this:

/reopen as closed by #5196 by mistake.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Jul 19 '24 09:07 karmada-bot

Kind ping @Akash-Singh04, do you have time to make a PR?

XiShanYongYe-Chang avatar Jul 25 '24 08:07 XiShanYongYe-Chang

Hi @yike21, we have one sub-mission left.

XiShanYongYe-Chang avatar Jul 29 '24 03:07 XiShanYongYe-Chang

Hi @yike21, we have one sub-mission left.

Hi @XiShanYongYe-Chang ! Let's wait a little bit for @Akash-Singh04 . If Akash-Singh04 is busy, I'll finish this part as soon as possible during the week.

yike21 avatar Jul 29 '24 04:07 yike21

Hey @XiShanYongYe-Chang Currently busy, feel free to make a PR :)

SkySingh04 avatar Jul 29 '24 05:07 SkySingh04

It seems all tasks are done. Great job! @yike21 Thanks to everyone who contribute to this task. /close

RainbowMango avatar Aug 09 '24 07:08 RainbowMango

@RainbowMango: Closing this issue.

In response to this:

It seems all tasks are done. Great job! @yike21 Thanks to everyone who contribute to this task. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Aug 09 '24 07:08 karmada-bot

Thank you all for the contributions!

yike21 avatar Aug 09 '24 12:08 yike21