fix: Deployment generation/observedGeneration bug

[veophi]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Part of #4870

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Project coverage is 28.22%. Comparing base (95e3264) to head (933343d). Report is 14 commits behind head on master.

Files	Patch %	Lines
...esourceinterpreter/default/native/reflectstatus.go	0.00%	17 Missing :warning:
...ourceinterpreter/default/native/aggregatestatus.go	80.00%	1 Missing and 2 partials :warning:
pkg/controllers/binding/common.go	0.00%	1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4867   +/-   ##
=======================================
  Coverage   28.22%   28.22%           
=======================================
  Files         632      632           
  Lines       43431    43454   +23     
=======================================
+ Hits        12259    12266    +7     
- Misses      30278    30291   +13     
- Partials      894      897    +3     

Flag	Coverage Δ
unittests	28.22% <35.29%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[XiShanYongYe-Chang]

Hi @veophi can you help fix the lint error?

[XiShanYongYe-Chang]

/assign @yike21

[veophi]

Hi @veophi can you help fix the lint error?

@XiShanYongYe-Chang fixed.

[XiShanYongYe-Chang]

Hi @veophi, Is this pr ready? If it is ready, you can remove the WIP info in the title. Then the work-in-progress label will be removed, indicating that the current pr is ready.

In addition, you can add the issue number of the current pr to the end of Fiexs, like this:

**Which issue(s) this PR fixes:**
Fixes #4866

and GitHub will automatically associate it with the issue. After the pr is merged, the associated issue will be closed.

[XiShanYongYe-Chang]

Part of #4870 /kind feature Hi @veophi, can you help add the release note.

[XiShanYongYe-Chang]

I see that there is a lot of discussion about this pr and the issues are quite in-depth. This means that the PR solution is very important to Karmada. Can we organize a meeting or discussion group to discuss this issue?

@veophi @whitewindmills @yike21

[RainbowMango]

By the way, I updated the PR description(Removed Fixes indicator) as it tries to fix the #4866, but it just focuses on Deployment.

[XiShanYongYe-Chang]

/assign

[XiShanYongYe-Chang]

This pr has made some updates, can you help to have a look again? cc @whitewindmills @chaunceyjiang @yike21 @RainbowMango

[RainbowMango]

/lgtm

@XiShanYongYe-Chang @whitewindmills @yike21 Do you have any further comments?

[XiShanYongYe-Chang]

Thanks a lot~ lgtm We need a release note in the PR description.

[yike21]

thanks a lot! lgtm

[whitewindmills]

/lgtm

[XiShanYongYe-Chang]

/lgtm

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~pkg/apis/OWNERS~~ [RainbowMango]
• ~~pkg/controllers/OWNERS~~ [RainbowMango]
• ~~pkg/resourceinterpreter/OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment