karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Cleanup the deprecated package of k8s.io/utils/pointer.

Open liangyuanpeng opened this issue 11 months ago • 15 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  1. Bump k8s.io/utils to 20240102154912-e7106e64919e
  2. cleanup the deprecated package of pointer, use k8s.io/utils/ptr instead.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


liangyuanpeng avatar Mar 18 '24 02:03 liangyuanpeng

Hi @liangyuanpeng the CI is failed.

XiShanYongYe-Chang avatar Mar 19 '24 02:03 XiShanYongYe-Chang

#3 ERROR: failed to do request: Head "https://registry-1.docker.io/v2/library/alpine/manifests/3.19.1": net/http: TLS handshake timeout
------
 > [internal] load metadata for docker.io/library/alpine:3.19.1:
------
Dockerfile:15
--------------------
  13 |     # limitations under the License.
  14 |     
  15 | >>> FROM alpine:3.19.1
  16 |     
  17 |     ARG BINARY
--------------------
ERROR: failed to solve: alpine:3.19.1: failed to do request: Head "https://registry-1.docker.io/v2/library/alpine/manifests/3.19.1": net/http: TLS handshake timeout
make: *** [Makefile:58: image-karmada-operator] Error 1
make: Leaving directory '/home/runner/work/karmada/karmada'
Error: Process completed with exit code 2.

CI CLI / init failed with timeout for pull alpine:3.19.1

liangyuanpeng avatar Mar 19 '24 08:03 liangyuanpeng

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.33%. Comparing base (d62287f) to head (ed0f26c).

Files Patch % Lines
...core/spreadconstraint/select_clusters_by_region.go 0.00% 1 Missing :warning:
pkg/util/lifted/federatedhpa.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4719   +/-   ##
=======================================
  Coverage   53.32%   53.33%           
=======================================
  Files         252      252           
  Lines       20539    20539           
=======================================
+ Hits        10953    10954    +1     
+ Misses       8861     8860    -1     
  Partials      725      725           
Flag Coverage Δ
unittests 53.33% <88.88%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 19 '24 09:03 codecov-commenter

/hold

liangyuanpeng avatar Mar 26 '24 05:03 liangyuanpeng

/reopen

liangyuanpeng avatar Mar 30 '24 12:03 liangyuanpeng

@liangyuanpeng: Failed to re-open PR: state cannot be changed. There are no new commits on the liangyuanpeng:cleanup_k8sutils_pointer branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karmada-bot avatar Mar 30 '24 12:03 karmada-bot

/reopen

liangyuanpeng avatar Mar 30 '24 12:03 liangyuanpeng

@liangyuanpeng: Failed to re-open PR: state cannot be changed. There are no new commits on the liangyuanpeng:cleanup_k8sutils_pointer branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karmada-bot avatar Mar 30 '24 12:03 karmada-bot

/hold cancel /assign @RainbowMango /assign @XiShanYongYe-Chang

liangyuanpeng avatar Mar 30 '24 14:03 liangyuanpeng

@liangyuanpeng Karmada usually keeps Kubernetes dependencies consistent, that's the reason why we use v0.0.0-20230406110748-d93618cff8a2 (which is consistent with Kubernetes v1.28.5). Given the k8s.io/utils/pointer hasn't been deprecated in v1.28.5(deprecated in v1.29), so I think we can postpone this for a while until we bump Kubernetes v1.29. What do you think?

In addition, we are waiting for https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/167 to bump Kuberentes dependencies v1.29.

RainbowMango avatar Apr 01 '24 02:04 RainbowMango

Thank you for your detailed explanation, it's make sense for me.

liangyuanpeng avatar Apr 08 '24 14:04 liangyuanpeng

Hi @liangyuanpeng We can get back on this now as the Kubernetes dependencies now is v1.29.4.

Bump k8s.io/utils to 20240102154912-e7106e64919e

We don't need to bump the version, right? We can cleanup the usage of deprecated packages though.

RainbowMango avatar May 06 '24 12:05 RainbowMango

I will update it ASAP.

liangyuanpeng avatar May 22 '24 07:05 liangyuanpeng

Kindly ping @liangyuanpeng This is the last blocker of #3835, probably.

Enable static check by removing these lines

RainbowMango avatar May 27 '24 08:05 RainbowMango

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar May 28 '24 07:05 karmada-bot