karmada icon indicating copy to clipboard operation
karmada copied to clipboard

GitHub Actions: Transitioning from Node 16 to Node 20

Open RainbowMango opened this issue 11 months ago • 3 comments

What would you like to be added: Bump GitHub Actions to transition all actions to run on Node 20 as Node 16 has reached its end of life.

  • actions/checkout@v3 --> actions/checkout@v4
  • actions/setup-go@v3 --> actions/setup-go@v4
  • arduino/setup-protoc@v1 --> arduino/setup-protoc@v3
  • codecov/codecov-action@v3 --> codecov/codecov-action@v4
  • actions/upload-artifact@v3 --> actions/upload-artifact@v4
  • engineerd/[email protected] (Seems the repo is inactive, is there a replacement?)
  • azure/setup-helm@v3 --> azure/setup-helm@v4
  • actions/setup-python@v4 --> actions/setup-python@v5
  • fossas/fossa-action@v1 --> fossas/[email protected]
  • github/codeql-action/upload-sarif@v2 --> github/codeql-action/upload-sarif@v3 Guide
  • docker/login-action@v2 --> docker/login-action@v3

Why is this needed: See the GitHub Actions: Transitioning from Node 16 to Node 20.

RainbowMango avatar Feb 29 '24 06:02 RainbowMango

Hello @RainbowMango , Can you assign this issue to me, I would like to work on it.

karnatisrinivas avatar Feb 29 '24 09:02 karnatisrinivas

Sure, go for it. Thanks. /assign @karnatisrinivas

RainbowMango avatar Feb 29 '24 12:02 RainbowMango

engineerd/[email protected] (Seems the repo is inactive, is there a replacement?)

Just looked at the helm/kind-action which looks like a good candidate for the engineerd/setup-kind.

In addition, I run a simple test and it works fine:

  • code change: https://github.com/karmada-io/karmada/commit/bde3cc85a7825855e776c30d64bae3e4835fde8b
  • workflow logs: https://github.com/RainbowMango/karmada/actions/runs/8135021485

RainbowMango avatar Mar 04 '24 02:03 RainbowMango

kindly ping @karnatisrinivas, are you still working on this? Feel free to let me know if you need any help.

RainbowMango avatar Mar 09 '24 06:03 RainbowMango

@karnatisrinivas Hi, I have create a PR #4714 to auto update github-actions, And you still can work for engineerd/[email protected] (Seems the repo is inactive, is there a replacement?)

liangyuanpeng avatar Mar 16 '24 14:03 liangyuanpeng

/unassign @karnatisrinivas As no response from @karnatisrinivas .

RainbowMango avatar Mar 25 '24 03:03 RainbowMango

/assign @RainbowMango @liangyuanpeng I will take the engineerd/setup-kind and perhaps the dependant bot could help with the others.

RainbowMango avatar Mar 27 '24 10:03 RainbowMango

I'm going to close this issue as the dependabot will fix them sooner or later. Note: Now dependabot will upgrade at most 5 dependencies a week.

RainbowMango avatar Apr 22 '24 07:04 RainbowMango

/close

RainbowMango avatar Apr 22 '24 07:04 RainbowMango

@RainbowMango: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karmada-bot avatar Apr 22 '24 07:04 karmada-bot