karmada
karmada copied to clipboard
feat: add informers replicaset transformer
What type of PR is this? /kind feature
What this PR does / why we need it: add replicaset transform
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
add replicaset transform
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.
Comparison is base (
9250219) 51.55% compared to head (2cd5fd3) 51.57%.
| Files | Patch % | Lines |
|---|---|---|
| pkg/util/fedinformer/transform.go | 70.37% | 8 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #4643 +/- ##
==========================================
+ Coverage 51.55% 51.57% +0.01%
==========================================
Files 250 250
Lines 24904 24931 +27
==========================================
+ Hits 12840 12857 +17
- Misses 11358 11367 +9
- Partials 706 707 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 51.57% <70.37%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dongjiang1989 Can you remind me why we need the transformer for ReplicaSet? Seems Karmada won't cache this kind of resource.
@dongjiang1989 Can you remind me why we need the transformer for
ReplicaSet? Seems Karmada won't cache this kind of resource.
Thanks, @RainbowMango. Hmmm... Maybe can use it. like: https://github.com/karmada-io/karmada/blob/f04c17f72749a8db253da7b2790b65d8e912ce24/pkg/estimator/server/server.go#L120
Hi @dongjiang1989, do we still need this pr?