Bump Prow to v20240216-16ababd181
Why is this needed: We want the feature that triggers failed workflow which was introduced since v20220105-8e97316bf9. See the discussion https://github.com/karmada-io/karmada/issues/3421#issuecomment-1751961909 for more details.
Migration progress:
I tested the basic functionality against the https://github.com/karmada-io/website/pull/563 and it works well.
The next step is to test the retest function.
Here is the main configuration update(add the triggers):
apiVersion: v1
kind: ConfigMap
metadata:
namespace: karmada-prowbot
name: config
data:
config.yaml: |
triggers:
- repos:
- karmada-io/karmada
- karmada-io/website
# JoinOrgURL is a link that redirects users to a location where they
# should be able to read more about joining the organization in order
# to become trusted members.
join_org_url: "https://github.com/karmada-io/community/blob/main/community-membership.md#member"
only_org_members: true
# TriggerGitHubWorkflows enables workflows run by github to be triggered by prow.
trigger_github_workflows: true
I tried it in my env and it works fine: https://github.com/jwcesign/kubectl-proxy-demo/pull/3
My config:
apiVersion: v1
kind: ConfigMap
metadata:
namespace: prow
name: plugins
data:
plugins.yaml: |
triggers:
- repos:
- jwcesign/kubectl-proxy-demo
trigger_github_workflows: true
plugins:
jwcesign/kubectl-proxy-demo:
plugins:
- approve
- assign
- blunderbuss
- cat
- dog
- help
- heart
- hold
- label
- lgtm
- trigger
- verify-owners
- wip
- yuks
Did the relevant components restart after the configuration update? @RainbowMango
It works now. See the test PR https://github.com/karmada-io/website/pull/567.
The Prow version now has been promoted to v20240517-ea10bd814. Thanks for your effort to make this happen. @jwcesign @zhzhuang-zju @liangyuanpeng
/close
@RainbowMango: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.