[umbrella] [Help Wanted] [Code Writing Wanted] Add e2e Test for Lazy activation Policy

[chaosi-zju]

What would you like to be added:

Add e2e Test for Lazy activation Policy.

A Lazy activation Policy is just like:

apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: policy-delay
spec:
  activationPreference: Lazy  # a new field added here, which refers to lazy activation Policy
  resourceSelectors:
    - apiVersion: apps/v1
      kind: Deployment
  placement:
    clusterAffinity:
      clusterNames:
        - member1
        - member2

Then, if a policy sets this field, the policy changes will not take effect immediately but defer to the resource template changes, in other words, the resource template will not be propagated as per the current propagation rules until there is an update on resource template itself.

You you want to known more:

• proposal PR: #4602
• implemention PR: #4577
• related issue: #4563

Why is this needed:

• Consolidate the test protection for the lazy activation feature.
• Help partners who are interested in the lazy activation feature to become more familiar with the detail behavior of it, and participate in contributing to the feature.
• Help beginners contributes code in karmada.

Which cases need to be done:

If you are interested in this activity, I can assign some of the e2e test to you.

All cases are listed in here.

TODO List:

• [x] Simple Case 1 (Policy created before resource) @Affan-7 #4622
• [x] Simple Case 2 (Policy created after resource) @chaosi-zju #4740
• [x] Simple Case 3 (Lazy to immediate) @hulizhe #4804
• [x] Simple Case 4 (Immediate to lazy) @hulizhe #4804
• [ ] Combined Case 1 (Policy deleted) @ewon78 #4668
• [ ] Combined Case 2 (Policy no longer match) @ewon78 #4668
• [x] Combined Case 3 (Policy preemption) @Affan-7 #5033
• [x] Combined Case 4 (Policy preemption) @hulizhe #4804
• [x] Combined Case 5 (Propagate dependencies) @chaosi-zju #4740
• [x] Combined Case 6 (Propagate dependencies) @chaosi-zju #4740

Feel free to ask me if there are any problems, and feel free to ask for assignment.

[Affan-7]

/assign

Let me give it a try.

[Affan-7]

Hi Chaosi,

I was wondering where should I add these tests. Should I add them in the propogationpolicy_test.go? Or should I create a new file like lazy_activation_policy_test.go?

[chaosi-zju]

I was wondering where should I add these tests. Should I add them in the propogationpolicy_test.go? Or should I create a new file like lazy_activation_policy_test.go?

Hi @Affan-7, sorry for the delay, and thank you very much for your enthusiasm~

I would prefer a new file like lazy_activation_policy_test.go.

Besides, which cases you would like choose? I can assign cases one batch by on batch to you~

Because I actually hope that more partners can be involved, which will help partners better understand this new feature. But since we are celebrating the New Year and most people are on vacation, there is not much popularity recently, haha~

[Affan-7]

I can work on Simple Case 1.

Because I actually hope that more partners can be involved, which will help partners better understand this new feature.

That sounds good! I appreciate your help and contributions to the community.

[chaosi-zju]

I can work on Simple Case 1.

Okey, your great effort will provide a important example to followers~ Looking forward to your PR~

Feel free to ask me if there are any problems.

[Affan-7]

Unassigning myself so people don't think that I am working on the whole issue.

[ewon78]

Can I work on this?

[chaosi-zju]

Can I work on this?

@ewon78 Hi, of course you can~

which cases would you prefer?

[zhzhuang-zju]

@chaosi-zju I can work on Simple Case 3 and Simple Case 4, thanks~

[ewon78]

@chaosi-zju thanks. I can work on Combined Case 1 & 2.

[chaosi-zju]

Ok, thank you for your enthusiasm @zhzhuang-zju @ewon78 ~

Besides, since another friend Affan-7 has submited a PR #4622 which haven't been merged, please be careful not to have too many conflicts on file names or common codes, thanks~

[Affan-7]

Hi @chaosi-zju, can you please assign me some more test cases?

[chaosi-zju]

can you please assign me some more test cases?

ok, of course, please just wait for a while~

[chaosi-zju]

@Affan-7 hi, Does [Combined Case 3] fit for you?

[hulizhe]

@chaosi-zju Hi, can I have a try on this?

[zhzhuang-zju]

@chaosi-zju Hi, can I have a try on this?

I'm glad you're willing to work on this. You can take my tasks, and feel free to ask any questions~

[chaosi-zju]

@ewon78 I'm very sorry for not following up your progress for a long time. I see that your PR CI failed. Can you rebase the latest code and deal with the CI problem? If you have any questions, please feel free to contact me. Thank you very much~

[chaosi-zju]

hi @Affan-7, long time no contact, how is it going for Combined Case 3, is there any time for you to go on? Or is here any problem? ٩(๑❛ᴗ❛๑)۶

[Affan-7]

Hi @chaosi-zju, I will surely get back to it on the weekends😅. I am not getting enough time to work on it.

[chaosi-zju]

I will surely get back to it on the weekends😅. I am not getting enough time to work on it.

OK! no rush, take your time :)