karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Remove annotaions when pp/cpp is deleted

Open zhzhuang-zju opened this issue 1 year ago • 5 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: Remove annotaions when pp/cpp is deleted Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

zhzhuang-zju avatar Jan 19 '24 07:01 zhzhuang-zju

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.07%. Comparing base (80ee3b2) to head (4842566).

Files Patch % Lines
pkg/detector/detector.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4561      +/-   ##
==========================================
- Coverage   53.08%   53.07%   -0.01%     
==========================================
  Files         251      251              
  Lines       20387    20387              
==========================================
- Hits        10822    10821       -1     
- Misses       8852     8853       +1     
  Partials      713      713              
Flag Coverage Δ
unittests 53.07% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 19 '24 07:01 codecov-commenter

cc @Vacant2333 @XiShanYongYe-Chang

zhzhuang-zju avatar Jan 20 '24 02:01 zhzhuang-zju

@zhzhuang-zju i will help u to review after the ci pass~~~

Vacant2333 avatar Jan 21 '24 09:01 Vacant2333

Thanks a lot /assign

XiShanYongYe-Chang avatar Jan 24 '24 01:01 XiShanYongYe-Chang

since https://github.com/karmada-io/karmada/pull/4743 has been merged, so this pr changes to add some related e2e scenarios @XiShanYongYe-Chang @Vacant2333

zhzhuang-zju avatar Apr 28 '24 07:04 zhzhuang-zju

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Apr 28 '24 09:04 karmada-bot