karmada icon indicating copy to clipboard operation
karmada copied to clipboard

introduce ExcludedResources to propagation policy to exclusionary selecting resource

Open chaosi-zju opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

introduce ExcludedResources to propagation policy to exclusionary selecting resource

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

this PR's reviewing should wait util #4510 and #4553 merged and do a rebase.

Does this PR introduce a user-facing change?:

introduce ExcludedResources to propagation policy to exclusionary selecting resource

chaosi-zju avatar Jan 16 '24 12:01 chaosi-zju

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign rainbowmango after the PR has been reviewed. You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jan 16 '24 12:01 karmada-bot

this PR's reviewing should wait util #4510 and #4553 merged and do a rebase.

/hold

chaosi-zju avatar Jan 16 '24 12:01 chaosi-zju

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (0aec7b5) 51.54% compared to head (ad99e67) 51.34%.

Files Patch % Lines
pkg/detector/policy.go 0.00% 79 Missing :warning:
pkg/util/selector.go 0.00% 29 Missing :warning:
pkg/detector/detector.go 0.00% 8 Missing :warning:
pkg/detector/compare.go 0.00% 2 Missing and 2 partials :warning:
pkg/detector/preemption.go 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4556      +/-   ##
==========================================
- Coverage   51.54%   51.34%   -0.21%     
==========================================
  Files         250      250              
  Lines       24904    25002      +98     
==========================================
- Hits        12838    12837       -1     
- Misses      11359    11456      +97     
- Partials      707      709       +2     
Flag Coverage Δ
unittests 51.34% <0.00%> (-0.21%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 16 '24 13:01 codecov-commenter

/hold cancel

chaosi-zju avatar Feb 05 '24 08:02 chaosi-zju