karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Is it appropriate to change `--skipped-propagating-apis` into `--managed-propagating-apis`?

Open snowplayfire opened this issue 2 years ago • 10 comments

What would you like to be added:

Why is this needed: It's more clear to know how many resources are managed by karmada, which is helpful to be aware of how much it has endured.

snowplayfire avatar Jul 31 '23 12:07 snowplayfire

@RainbowMango @XiShanYongYe-Chang please have a look.

snowplayfire avatar Jul 31 '23 12:07 snowplayfire

--skipped-propagating-apis is a kind of ignore list, but the --managed-propagating-apis is a kind of allowed list, Do you mean people have to edit the configuration every time they add a new CRD?

RainbowMango avatar Jul 31 '23 13:07 RainbowMango

How about Hot reload allowed list? The implementation method is open to further discussion.

snowplayfire avatar Jul 31 '23 13:07 snowplayfire

which is helpful to be aware of how much it has endured

I'd like to hear more details about this requirement. We might have other solutions.

RainbowMango avatar Jul 31 '23 13:07 RainbowMango

How about talking about it at tomorrow's community meeting?

RainbowMango avatar Jul 31 '23 13:07 RainbowMango

How about talking about it at tomorrow's community meeting?

ok

snowplayfire avatar Jul 31 '23 13:07 snowplayfire

I just added an agenda for you.

RainbowMango avatar Aug 01 '23 04:08 RainbowMango

It seems like there are four ways to achieve it:

  1. add --skipped-propagating-apis as params of karmada-controller-manager: API is not intuitive to users、lack of management、lack of visualization
  2. managed as a allowed list by RBAC: not intuitive to users too, somewhat tricky
  3. add a new API: the workload involved may be a bit larger
  4. managed as a allowed list in ConfigMap: similar to "add a new API" in basic principle, but not as clear as it is

So, I prefer to add a new API, which names like PropagateAPIList, then we can define the propagating-apis managed/skipped as a allow/ignore list in spec field, and we can observe how many resources are managed or how much it has endured in status field by kubectl. I favour it for its intuitive and visualization.

chaosi-zju avatar Aug 17 '23 13:08 chaosi-zju

Is anything updated for the issue? It seems the point is how to show objects that the karmada controlled. Can we just create a default propagationpolicy and make it show all resources the karmada controlled? The pp needn't to be in effect and it doesn't need to add new API. By the way, it seems detector won't process resource objects without matched propagationpolicy, is it right?

majoyz avatar Sep 25 '23 08:09 majoyz

Can we just create a default propagationpolicy and make it show all resources the karmada controlled? The pp needn't to be in effect and it doesn't need to add new API.

What's the default PropagationPolicy look like? Who is responsible for creating it and recording the resource list?

By the way, it seems detector won't process resource objects without matched propagationpolicy, is it right?

Yes, the unmatched resources will be put on a waiting list.

RainbowMango avatar Oct 07 '23 02:10 RainbowMango

/close Please feel free to re-open it if you still need it.

RainbowMango avatar May 29 '24 09:05 RainbowMango

@RainbowMango: Closing this issue.

In response to this:

/close Please feel free to re-open it if you still need it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar May 29 '24 09:05 karmada-bot