New Factory global flags merge function
What type of PR is this? /kind feature
What this PR does / why we need it: These code comes multiple times, we may extract them as one function. Which issue(s) this PR fixes: Fixes # Port #2611 Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
Other lgtm
/retest
/cc @lonelyCZ
/retest
I just tested it, and it worked fine in my env.
Hi, @RainbowMango , please help to retrigger the workflows.
PTAL
/cc @carlory
Please take a look~
/cc @carlory
It works fine in my env.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lonelyCZ
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/karmadactl/OWNERS~~ [lonelyCZ]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Change the label to the correct one. /kind cleanup /remove-kind feature