karmada icon indicating copy to clipboard operation
karmada copied to clipboard

New Factory global flags merge function

Open helen-frank opened this issue 3 years ago • 3 comments

What type of PR is this? /kind feature

What this PR does / why we need it: These code comes multiple times, we may extract them as one function. Which issue(s) this PR fixes: Fixes # Port #2611 Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

helen-frank avatar Oct 25 '22 11:10 helen-frank

Other lgtm

jwcesign avatar Oct 26 '22 09:10 jwcesign

/retest

helen-frank avatar Oct 29 '22 15:10 helen-frank

/cc @lonelyCZ

helen-frank avatar Nov 07 '22 08:11 helen-frank

/retest

helen-frank avatar Nov 07 '22 10:11 helen-frank

I just tested it, and it worked fine in my env.

Hi, @RainbowMango , please help to retrigger the workflows.

lonelyCZ avatar Nov 08 '22 11:11 lonelyCZ

PTAL

/cc @carlory

lonelyCZ avatar Nov 08 '22 11:11 lonelyCZ

Please take a look~

/cc @carlory

lonelyCZ avatar Nov 09 '22 05:11 lonelyCZ

It works fine in my env.

/lgtm /approve

lonelyCZ avatar Nov 10 '22 01:11 lonelyCZ

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Nov 10 '22 02:11 karmada-bot

Change the label to the correct one. /kind cleanup /remove-kind feature

XiShanYongYe-Chang avatar Nov 29 '22 07:11 XiShanYongYe-Chang