karmada
karmada copied to clipboard
chart: enable estimator component for scheduler
Signed-off-by: calvin [email protected]
What type of PR is this? /kind feature
What this PR does / why we need it: currently, we cannot enable estimator for schedler. we need a switch to open the feature in weight-schedule.

Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer: please correct me if not.
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign pidb after the PR has been reviewed.
You can assign the PR to them by writing /assign @pidb
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Merging #2620 (e94d3fe) into master (68a9628) will increase coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
Coverage 37.70% 37.71%
=======================================
Files 200 200
Lines 18435 18435
=======================================
+ Hits 6951 6952 +1
+ Misses 11079 11077 -2
- Partials 405 406 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 37.71% <ø> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/util/worker.go | 66.66% <0.00%> (-4.77%) |
:arrow_down: |
pkg/search/proxy/store/util.go | 94.31% <0.00%> (+1.89%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@Poor12 PTAL
@Poor12 any suggests?
Please update the README.md together.
/assign @Poor12
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from poor12 after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/retest
@calvin0327 The /retest command not working. I just re-triggered the tests.