karmada icon indicating copy to clipboard operation
karmada copied to clipboard

chart: enable estimator component for scheduler

Open calvin0327 opened this issue 2 years ago • 3 comments

Signed-off-by: calvin [email protected]

What type of PR is this? /kind feature

What this PR does / why we need it: currently, we cannot enable estimator for schedler. we need a switch to open the feature in weight-schedule.

image

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: please correct me if not.

Does this PR introduce a user-facing change?:

NONE

calvin0327 avatar Oct 08 '22 02:10 calvin0327

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign pidb after the PR has been reviewed. You can assign the PR to them by writing /assign @pidb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 08 '22 02:10 karmada-bot

Codecov Report

Merging #2620 (e94d3fe) into master (68a9628) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2620   +/-   ##
=======================================
  Coverage   37.70%   37.71%           
=======================================
  Files         200      200           
  Lines       18435    18435           
=======================================
+ Hits         6951     6952    +1     
+ Misses      11079    11077    -2     
- Partials      405      406    +1     
Flag Coverage Δ
unittests 37.71% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/worker.go 66.66% <0.00%> (-4.77%) :arrow_down:
pkg/search/proxy/store/util.go 94.31% <0.00%> (+1.89%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 08 '22 02:10 codecov-commenter

@Poor12 PTAL

calvin0327 avatar Oct 08 '22 02:10 calvin0327

@Poor12 any suggests?

calvin0327 avatar Nov 20 '22 12:11 calvin0327

Please update the README.md together.

Poor12 avatar Nov 21 '22 01:11 Poor12

/assign @Poor12

RainbowMango avatar Nov 28 '22 09:11 RainbowMango

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from poor12 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Nov 30 '22 11:11 karmada-bot

/retest

calvin0327 avatar Dec 05 '22 02:12 calvin0327

@calvin0327 The /retest command not working. I just re-triggered the tests.

RainbowMango avatar Dec 05 '22 04:12 RainbowMango