karmada
karmada copied to clipboard
Fix serviceaccount continual regeneration by service account controller
Signed-off-by: Poor12 [email protected]
What type of PR is this? /kind bug
What this PR does / why we need it: For serviceAccount, we don't retain that in control plane but merge that in control plane and member clusters. You can based on https://github.com/karmada-io/karmada/issues/2573#issuecomment-1256844989.
Which issue(s) this PR fixes: Fixes #2573
Special notes for your reviewer:
Does this PR introduce a user-facing change?: None
/cc @XiShanYongYe-Chang @RainbowMango
Codecov Report
Merging #2578 (c37f34b) into master (c817ace) will increase coverage by
0.08%
. The diff coverage is73.68%
.
@@ Coverage Diff @@
## master #2578 +/- ##
==========================================
+ Coverage 23.05% 23.13% +0.08%
==========================================
Files 183 183
Lines 18393 18398 +5
==========================================
+ Hits 4240 4256 +16
+ Misses 13820 13805 -15
- Partials 333 337 +4
Flag | Coverage Δ | |
---|---|---|
unittests | 23.13% <73.68%> (+0.08%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/util/lifted/retain.go | 72.13% <73.68%> (+25.07%) |
:arrow_up: |
pkg/karmadactl/cmdinit/kubernetes/deploy.go | 0.82% <0.00%> (-1.08%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment