karmada
karmada copied to clipboard
addons enable cluster flag usage description wrong
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This cluster is used on the enable and disable command lines, and the description here obviously does not match the actual description of the cluster
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
/cc @carlory @wuyingjun-lucky
Thank you for finding this. @lixingchenDaoCloud I am not sure the updated description is fit. @carlory @lonelyCZ can you help ?
/lgtm
Codecov Report
Merging #2577 (4039fbf) into master (e7d4f46) will increase coverage by
0.08%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #2577 +/- ##
==========================================
+ Coverage 23.39% 23.48% +0.08%
==========================================
Files 184 184
Lines 18484 18484
==========================================
+ Hits 4325 4341 +16
+ Misses 13812 13798 -14
+ Partials 347 345 -2
Flag | Coverage Δ | |
---|---|---|
unittests | 23.48% <ø> (+0.08%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/util/serviceaccount.go | 50.00% <0.00%> (+22.22%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/karmadactl/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment