karmada icon indicating copy to clipboard operation
karmada copied to clipboard

addons enable cluster flag usage description wrong

Open lixingchenDaoCloud opened this issue 2 years ago • 3 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This cluster is used on the enable and disable command lines, and the description here obviously does not match the actual description of the cluster image

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

lixingchenDaoCloud avatar Sep 24 '22 14:09 lixingchenDaoCloud

/cc @carlory @wuyingjun-lucky

lixingchenDaoCloud avatar Sep 24 '22 14:09 lixingchenDaoCloud

Thank you for finding this. @lixingchenDaoCloud I am not sure the updated description is fit. @carlory @lonelyCZ can you help ?

wuyingjun-lucky avatar Sep 24 '22 14:09 wuyingjun-lucky

/lgtm

wuyingjun-lucky avatar Oct 13 '22 06:10 wuyingjun-lucky

Codecov Report

Merging #2577 (4039fbf) into master (e7d4f46) will increase coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2577      +/-   ##
==========================================
+ Coverage   23.39%   23.48%   +0.08%     
==========================================
  Files         184      184              
  Lines       18484    18484              
==========================================
+ Hits         4325     4341      +16     
+ Misses      13812    13798      -14     
+ Partials      347      345       -2     
Flag Coverage Δ
unittests 23.48% <ø> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/serviceaccount.go 50.00% <0.00%> (+22.22%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 13 '22 06:10 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 13 '22 07:10 karmada-bot