karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Fix the issue that incomingBindingMetrics ignores the ClusterChanged event

Open Poor12 opened this issue 2 years ago • 1 comments

Signed-off-by: Poor12 [email protected]

What type of PR is this? /kind cleanup

What this PR does / why we need it: Add metrics test for scheduler.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: None

Poor12 avatar Sep 21 '22 02:09 Poor12

/cc @RainbowMango

Poor12 avatar Sep 27 '22 12:09 Poor12

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ab88988). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2555   +/-   ##
=========================================
  Coverage          ?   23.16%           
=========================================
  Files             ?      183           
  Lines             ?    18396           
  Branches          ?        0           
=========================================
  Hits              ?     4261           
  Misses            ?    13798           
  Partials          ?      337           
Flag Coverage Δ
unittests 23.16% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 30 '22 07:09 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 30 '22 07:09 karmada-bot