karmada icon indicating copy to clipboard operation
karmada copied to clipboard

chart: install components with host mode

Open calvin0327 opened this issue 2 years ago • 6 comments

Signed-off-by: calvin0327 [email protected]

What type of PR is this? /kind feature

What this PR does / why we need it: install together karmada and its component together use host installMode. this is test result: image

Which issue(s) this PR fixes: Fixes https://github.com/karmada-io/karmada/issues/2290

Special notes for your reviewer: please correct me if not.

Does this PR introduce a user-facing change?:

NONE

calvin0327 avatar Sep 11 '22 06:09 calvin0327

@Poor12 PTAL

calvin0327 avatar Sep 11 '22 06:09 calvin0327

/retest

calvin0327 avatar Sep 11 '22 11:09 calvin0327

Hi @calvin0327, you can pull and rebase this pr to retrigger the CI.

Poor12 avatar Sep 13 '22 02:09 Poor12

/lgtm

Poor12 avatar Sep 19 '22 09:09 Poor12

Codecov Report

Merging #2507 (3674e9f) into master (e693dfe) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2507   +/-   ##
=======================================
  Coverage   23.12%   23.12%           
=======================================
  Files         183      183           
  Lines       18424    18424           
=======================================
  Hits         4261     4261           
  Misses      13826    13826           
  Partials      337      337           
Flag Coverage Δ
unittests 23.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 08 '22 02:10 codecov-commenter

/lgtm

Poor12 avatar Oct 08 '22 03:10 Poor12

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 08 '22 08:10 karmada-bot