karmada
karmada copied to clipboard
karmada-io
karmadactl are compatible with v1.24 master node label
Signed-off-by: calvin0327 [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
if the k8s cluster is v1.24, we can not use the previous label to select master node.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer: please correct me if not.
Does this PR introduce a user-facing change?:
NONE
if the k8s cluster is v1.24, we can not use the previous label to select master node.
Why? Do you mean the label changed at v1.24? Can you show me the link to the release note?
if the k8s cluster is v1.24, we can not use the previous label to select master node.
Why? Do you mean the label changed at v1.24? Can you show me the link to the release note?
https://kubernetes.io/blog/2022/04/07/upcoming-changes-in-kubernetes-1-24/#api-removals-deprecations-and-other-changes-for-kubernetes-1-24 https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/2067-rename-master-label-taint#summary
@RainbowMango right, In v1.24, the master node replace label node-role.kubernetes.io/master with node-role.kubernetes.io/master.
@chaunceyjiang thanks.
Hi @calvin0327 , It is important improvement. Please rebase this pr, the code base has been changed despite no conflicts. I will review it.
/assign
Sorry, it seems I missed this :( I put this to milstone v1.4, then we won't forget it.
Avoid to block the function, merging it firstly.
/lgtm
/assign @RainbowMango
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/karmadactl/cmdinit/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
