karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[lfx-mentorship-2022-Sept-Nov] Configurable Interpreter

Open RainbowMango opened this issue 3 years ago • 9 comments

What would you like to be added: Now in Resource Interpreter framework, we enabled both built-in and customized interpreter.

We'd like to enable the third interpreter, which is configurable interpreter.

In addition, for the Retain interpreter operation, we have the proposal .

Following documents would help to understand this task:

Why is this needed:

Iteration tasks

  • [x] First API get on board (@RainbowMango, #2639)
  • [x] The rest APIs for interface (@RainbowMango, #2681)
  • [ ] Resource Interpreter framework cache and reorganize configurations
  • [ ] Resource Interpreter framework introduce Lua runtime layer
  • [ ] Resource Interpreter implements the interfaces
  • [ ] Introduce a subcommand interpret to karmadactl for the user to verify the Lua scripts.
  • [ ] E2E coverage
  • [ ] ValidatingAdmission tasks
  • [ ] TBD

RainbowMango avatar Aug 12 '22 09:08 RainbowMango

Hey @RainbowMango I am interested in this project for LFX-Mentorship, will you provide me more information to get started?

PradyumnaKrishna avatar Aug 18 '22 02:08 PradyumnaKrishna

I updated a document list to the issue description.

RainbowMango avatar Aug 18 '22 02:08 RainbowMango

Hey @RainbowMango, I have read the proposal,documents and the struct and believe we need to build a webhook and write a lua/cue script which contains the logic to retain the configured field by the user to sync changes so the there is no endless loop in karmada control plane. After that we need to register it here cmd/webhook/app/webhook.go . I am interested in solving this issue , Get me on board for this one.

basit9958 avatar Aug 21 '22 20:08 basit9958

/assign

jameszhangyukun avatar Sep 03 '22 06:09 jameszhangyukun

Friendly ping @jameszhangyukun Any progress?

chaunceyjiang avatar Oct 20 '22 09:10 chaunceyjiang

Hi @chaunceyjiang @jameszhangyukun made a demo for this.

The next step I think is Resource Interpreter framework cache and reorganize configurations.

RainbowMango avatar Oct 20 '22 09:10 RainbowMango

Hi @jameszhangyukun, I'll be involved with you in the development of this work, thanks~

XiShanYongYe-Chang avatar Oct 26 '22 09:10 XiShanYongYe-Chang

Hi, @jameszhangyukun @RainbowMango @XiShanYongYe-Chang I am also very interested in this, can I participate in the development together?

chaunceyjiang avatar Oct 31 '22 10:10 chaunceyjiang

Hi, @jameszhangyukun @RainbowMango @XiShanYongYe-Chang I am also very interested in this, can I participate in the development together?

Of course, thank you very much.

XiShanYongYe-Chang avatar Nov 02 '22 08:11 XiShanYongYe-Chang

Thank you @chaunceyjiang @ikaven1024 @jameszhangyukun @XiShanYongYe-Chang for all your effort in this feature. It's a big success for all of us!

Most of the planned features have been done and will be delivered with the coming v1.4.0. For the rest of the improvement task, let's do it in the next release. /close

RainbowMango avatar Nov 30 '22 02:11 RainbowMango

@RainbowMango: Closing this issue.

In response to this:

Thank you @chaunceyjiang @ikaven1024 @jameszhangyukun @XiShanYongYe-Chang for all your effort in this feature. It's a big success for all of us!

Most of the planned features have been done and will be delivered with the coming v1.4.0. For the rest of the improvement task, let's do it in the next release. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karmada-bot avatar Nov 30 '22 02:11 karmada-bot