karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Cluster resource modeling

Open halfrost opened this issue 3 years ago • 3 comments

This pr is for issue #772 . My solution is the picture below:

change splay tree to red black tree.

halfrost avatar Aug 12 '22 01:08 halfrost

Welcome @halfrost! It looks like this is your first PR to karmada-io/karmada 🎉

karmada-bot avatar Aug 12 '22 01:08 karmada-bot

Hi, @halfrost, please check DCO and other CI failure.

Poor12 avatar Aug 12 '22 01:08 Poor12

cc @RainbowMango to start CI

Poor12 avatar Aug 15 '22 08:08 Poor12

Hi @halfrost @Poor12 created an issue(#2379) to track the whole task, he will work with you to finish it.

RainbowMango avatar Aug 15 '22 10:08 RainbowMango

Hi @halfrost @Poor12 created an issue(#2379) to track the whole task, he will work with you to finish it.

Sounds great. We will try our best to complete this task together.

halfrost avatar Aug 16 '22 03:08 halfrost

@Poor12 I have already split API part out of this pr. Please review API part in this pr https://github.com/karmada-io/karmada/pull/2386

halfrost avatar Aug 16 '22 04:08 halfrost

@halfrost I tried to fix the CI failure and pushed the commits to your branch on your forked GitHub repo.

Now the CI failure is due to #2404 and is not available in the period August 22, 12:00 UTC - August 22, 16:00 UTC. You can rebase your branch and push again, or I'll retrigger it tomorrow.

RainbowMango avatar Aug 22 '22 13:08 RainbowMango

Generallly look good to me,cc @RainbowMango

Poor12 avatar Aug 23 '22 09:08 Poor12

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 23 '22 12:08 karmada-bot