karmada icon indicating copy to clipboard operation
karmada copied to clipboard

fix the problem that CRD cannot be searched

Open fly2F opened this issue 2 years ago • 10 comments

convert to GVR using meta.UnsafeGuessKindToResource

Co-authored-by: liys87x [email protected] Signed-off-by: huntsman_ly [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #2226

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


fly2F avatar Aug 10 '22 13:08 fly2F

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from liys87x after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 10 '22 13:08 karmada-bot

@XiShanYongYe-Chang @RainbowMango Is it possible to convert GVK using meta.UnsafeGuessKindToResource

fly2F avatar Aug 10 '22 13:08 fly2F

@XiShanYongYe-Chang @RainbowMango Is it possible to convert GVK using meta.UnsafeGuessKindToResource

This function appears to be just a word analysis. It needs to be assumed in advance that users create CRDs according to this rule, which has certain limitations.

XiShanYongYe-Chang avatar Aug 11 '22 02:08 XiShanYongYe-Chang

@XiShanYongYe-Chang @RainbowMango Is it possible to convert GVK using meta.UnsafeGuessKindToResource

This function appears to be just a word analysis. It needs to be assumed in advance that users create CRDs according to this rule, which has certain limitations.

Yes, but using restmapper requires active connection to each member cluster

fly2F avatar Aug 11 '22 02:08 fly2F

Yes, but using restmapper requires active connection to each member cluster

It's just an idea, can we make a constraint that crd resources need to be installed on the karmada control-plane?

XiShanYongYe-Chang avatar Aug 11 '22 02:08 XiShanYongYe-Chang

The unmodified version makes this assumption. How do we make the constraint ?

fly2F avatar Aug 11 '22 02:08 fly2F

The unmodified version makes this assumption. How do we make the constraint ?

How about putting the constraint into the document for using search feature? Currently, we have not added documents about the use of the search feature.

XiShanYongYe-Chang avatar Aug 11 '22 02:08 XiShanYongYe-Chang

The unmodified version makes this assumption. How do we make the constraint ?

How about putting the constraint into the document for using search feature? Currently, we have not added documents about the use of the search feature.

Great idea, I'll submit a document asap

fly2F avatar Aug 11 '22 02:08 fly2F

Great idea, I'll submit a document asap

Thanks very much!

XiShanYongYe-Chang avatar Aug 11 '22 03:08 XiShanYongYe-Chang

/assign @XiShanYongYe-Chang

RainbowMango avatar Aug 12 '22 08:08 RainbowMango

We will describe the types of resources that can be searched by writing usage documentation

fly2F avatar Aug 26 '22 00:08 fly2F