karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[Umbrella] karmadactl uses factory instead of karmadaConfig

Open carlory opened this issue 2 years ago • 2 comments

What would you like to be added:

Iterated task:

  • [x] karmadactl logs uses factory #2202
  • [x] karmadactl apply uses factory
  • [x] karmadactl describe uses factory #2471
  • [x] karmadactl exec uses factory #2470
  • [ ] karmadactl get uses factory
  • [ ] karmadactl promote uses factory
  • [ ] karmadactl taint uses factory
  • [ ] all sub command accepts factory as input parameter

Why is this needed:

At present, there are many places in karmadactl, which are building clients and factories for member cluster repeatedly, such as init, get, log, exec, etc.

#2202 introduces factory interface, and try to resolve it.

/assign

carlory avatar Aug 09 '22 08:08 carlory

I would working for karmadactl promote.

liangyuanpeng avatar Oct 07 '22 07:10 liangyuanpeng

I would working for karmadactl promote.

Hi @liangyuanpeng , have it moved forward?

And I consider to optimize the code style of karmadactl at #2664 , let's push ahead this issue.

lonelyCZ avatar Oct 21 '22 07:10 lonelyCZ