karmada
karmada copied to clipboard
Update karmada charts to support Support set `global.imageRegistry` of all components image repo
What type of PR is this?
/kind feature
What this PR does / why we need it:
karmada helm charts support specifying a unified image repository. In this way, we can also directly set the global registry address in the offline environment, which is very convenient to install karmada
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
At present, the two images of cfssl and kubectl cannot be specified through global.imageRegistry
, which is very unfriendly in offline environment. So try to make these two images also manageable through global.imageRegistry
test results:
helm template --set global.imageRegistry="swr.ap-southeast-1.myhuaweicloud.com" . | grep "image:"
image: swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-aggregated-apiserver:latest
image: swr.ap-southeast-1.myhuaweicloud.com/kube-apiserver:v1.24.2
image: swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-controller-manager:latest
image: swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-scheduler:latest
image: swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-webhook:latest
image: swr.ap-southeast-1.myhuaweicloud.com/kube-controller-manager:v1.24.2
image: swr.ap-southeast-1.myhuaweicloud.com/etcd:3.5.3-0
image: swr.ap-southeast-1.myhuaweicloud.com/bitnami/kubectl:latest
image: swr.ap-southeast-1.myhuaweicloud.com/bitnami/kubectl:latest
image: swr.ap-southeast-1.myhuaweicloud.com/cfssl/cfssl:latest
image: swr.ap-southeast-1.myhuaweicloud.com/bitnami/kubectl:latest
Does this PR introduce a user-facing change?:
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~charts/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment