chart: add descheduler name suffix of chart deployment manifest

[calvin0327]

Signed-off-by: calvin0327 [email protected]

What type of PR is this? /kind bug

What this PR does / why we need it: the descheduler missing name suffix after install with helm.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign pidb after the PR has been reviewed. You can assign the PR to them by writing /assign @pidb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[calvin0327]

@Poor12 PTAL

[Poor12]

Actually, it's an issue about user habits. When users use descheduler as release name, it's ok. But when users use karmada-descheduler the issue will occur, too. I perfer to use complete name as release name, based on https://github.com/karmada-io/karmada/blob/master/charts/karmada/README.md.

[calvin0327]

https://github.com/karmada-io/karmada/blob/master/charts/karmada/templates/karmada-search.yaml#L7 https://github.com/karmada-io/karmada/blob/master/charts/karmada/templates/karmada-scheduler-estimator.yaml#L8 https://github.com/karmada-io/karmada/blob/master/charts/karmada/templates/karmada-descheduler.yaml#L6

@Poor12 ok, I got your means. but the three components name is not consistent.

[RainbowMango]

/assign @Poor12

[Poor12]

For this issue, I think the name in karmada-search should change to ${name}. Karmada-scheduler-estimator is a little special. It's ok to maintain the status. Could you modify the corresponding yaml？Then we can go on.

[calvin0327]

@Poor12 https://github.com/karmada-io/karmada/pull/2507 in the pr we install karmada and karmada component with hostMode, if we delete suffix of components, the following will happen, we cannot konw what the pod is, unless we get the pod yaml.

[Poor12]

I mean that in fact, we can't guarantee what the user enters, but we prefer the user to enter the full name when installing optional components.

[Poor12]

I mean that in fact, we can't guarantee what the user enters, but we prefer the user to enter the full name when installing optional components. Using hostmode to install optional components does cause problems. In that case, use {name}-suffix may be a better choice.

[calvin0327]

@Poor12 yes, it's seem not problem when install optional components in component mode with {name}-suffix. In this way, both modes are compatible.

[Poor12]

Since #2507 is merged, I think we can move this pr on. Could you please update the docs by the way? And I think we can delete the section about installing karmada-descheduler and add descriptions for installing components with host mode instead.

[calvin0327]

Since #2507 is merged, I think we can move this pr on. Could you please update the docs by the way? And I think we can delete the section about installing karmada-descheduler and add descriptions for installing components with host mode instead.

OKey, Agree with you.

[Poor12]

/lgtm

[codecov-commenter]

Codecov Report

Merging #2300 (8375a9f) into master (f00b3eb) will increase coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
+ Coverage   23.11%   23.20%   +0.08%     
==========================================
  Files         183      183              
  Lines       18424    18424              
==========================================
+ Hits         4259     4275      +16     
+ Misses      13826    13812      -14     
+ Partials      339      337       -2     

Flag	Coverage Δ
unittests	23.20% <ø> (+0.08%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/util/serviceaccount.go	50.00% <0.00%> (+22.22%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~charts/OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment