karmada icon indicating copy to clipboard operation
karmada copied to clipboard

disable flags in use line

Open carlory opened this issue 2 years ago • 2 comments

Signed-off-by: carlory [email protected]

What type of PR is this? /kind feature

What this PR does / why we need it:

After #2283 is merged, Flags are renamed to options. We should disable flags in useline for karmada sub command.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

carlory avatar Aug 01 '22 12:08 carlory

/cc @lonelyCZ @prodanlabs

carlory avatar Aug 04 '22 06:08 carlory

/cc @lonelyCZ

carlory avatar Aug 16 '22 12:08 carlory

/cc @lonelyCZ

carlory avatar Sep 02 '22 08:09 carlory

Thanks @carlory , I will review it ASAP.

/assign

lonelyCZ avatar Sep 04 '22 14:09 lonelyCZ

@lonelyCZ updated

carlory avatar Sep 06 '22 03:09 carlory

Looks good, perhaps you need to retrigger the CI. @carlory

lonelyCZ avatar Sep 06 '22 12:09 lonelyCZ

I can re-trigger the test, but could any one help to analyze the reason? To see if there is any point that can be optimized.

RainbowMango avatar Sep 06 '22 13:09 RainbowMango

cc @XiShanYongYe-Chang

RainbowMango avatar Sep 06 '22 13:09 RainbowMango

Resource names conflict between E2E test cases, resulting in unexpected behavior. Therefore, we need to adjust the length of the random number, for example, change 3 to 5:

https://github.com/karmada-io/karmada/blob/49fd8180c8fe2f85df7cd8a1bf5d6a51717c48b5/test/e2e/suite_test.go#L35-L36

XiShanYongYe-Chang avatar Sep 07 '22 02:09 XiShanYongYe-Chang

Retriggered.

RainbowMango avatar Sep 07 '22 03:09 RainbowMango

@lonelyCZ It's ready for review.

carlory avatar Sep 07 '22 06:09 carlory

Thanks @carlory

/lgtm /approve

lonelyCZ avatar Sep 08 '22 01:09 lonelyCZ

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 08 '22 01:09 karmada-bot