karmada
karmada copied to clipboard
disable flags in use line
Signed-off-by: carlory [email protected]
What type of PR is this? /kind feature
What this PR does / why we need it:
After #2283 is merged, Flags are renamed to options. We should disable flags in useline for karmada sub command.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
/cc @lonelyCZ @prodanlabs
/cc @lonelyCZ
/cc @lonelyCZ
Thanks @carlory , I will review it ASAP.
/assign
@lonelyCZ updated
Looks good, perhaps you need to retrigger the CI. @carlory
I can re-trigger the test, but could any one help to analyze the reason? To see if there is any point that can be optimized.
cc @XiShanYongYe-Chang
Resource names conflict between E2E test cases, resulting in unexpected behavior. Therefore, we need to adjust the length of the random number, for example, change 3 to 5:
https://github.com/karmada-io/karmada/blob/49fd8180c8fe2f85df7cd8a1bf5d6a51717c48b5/test/e2e/suite_test.go#L35-L36
Retriggered.
@lonelyCZ It's ready for review.
Thanks @carlory
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lonelyCZ
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/karmadactl/OWNERS~~ [lonelyCZ]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment