karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Standardize the generation of certificates for karmadactl init

Open lonelyCZ opened this issue 2 years ago • 3 comments

Signed-off-by: lonelyCZ [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

[root@master67 karmada]# tree
.
├── crds
│   ├── bases
│   │   ├── config.karmada.io_resourceinterpreterwebhookconfigurations.yaml
│   │   ├── multicluster.x-k8s.io_serviceexports.yaml
│   │   ├── multicluster.x-k8s.io_serviceimports.yaml
│   │   ├── networking.karmada.io_multiclusteringresses.yaml
│   │   ├── policy.karmada.io_clusteroverridepolicies.yaml
│   │   ├── policy.karmada.io_clusterpropagationpolicies.yaml
│   │   ├── policy.karmada.io_federatedresourcequotas.yaml
│   │   ├── policy.karmada.io_overridepolicies.yaml
│   │   ├── policy.karmada.io_propagationpolicies.yaml
│   │   ├── work.karmada.io_clusterresourcebindings.yaml
│   │   ├── work.karmada.io_resourcebindings.yaml
│   │   └── work.karmada.io_works.yaml
│   ├── kustomization.yaml
│   └── patches
│       ├── webhook_in_clusterresourcebindings.yaml
│       └── webhook_in_resourcebindings.yaml
├── crds.tar.gz
├── karmada-agent.yaml
├── karmada-apiserver.config
├── karmada-scheduler-estimator.yaml
└── pki
    ├── ca.crt
    ├── ca.key
    ├── etcd-ca.crt
    ├── etcd-ca.key
    ├── etcd-client.crt
    ├── etcd-client.key
    ├── etcd-server.crt
    ├── etcd-server.key
    ├── front-proxy-ca.crt
    ├── front-proxy-ca.key
    ├── front-proxy-client.crt
    ├── front-proxy-client.key
    ├── karmada.crt
    └── karmada.key

Which issue(s) this PR fixes: Part of #2282

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

lonelyCZ avatar Aug 01 '22 12:08 lonelyCZ

Unify format

[root@master67 karmada]# tree
.
├── crds.tar.gz
├── karmada-agent.yaml
├── karmada-apiserver.config
├── karmada-scheduler-estimator.yaml
└── pki
    ├── apiserver.crt
    ├── apiserver.key
    ├── ca.crt
    ├── ca.key
    ├── etcd-ca.crt
    ├── etcd-ca.key
    ├── etcd-client.crt
    ├── etcd-client.key
    ├── etcd-server.crt
    ├── etcd-server.key
    ├── front-proxy-ca.crt
    ├── front-proxy-ca.key
    ├── front-proxy-client.crt
    ├── front-proxy-client.key
    ├── karmada.crt
    └── karmada.key

lonelyCZ avatar Aug 02 '22 06:08 lonelyCZ

I will review it ASAP this week.

carlory avatar Aug 04 '22 06:08 carlory

/cc @RainbowMango

lonelyCZ avatar Aug 16 '22 07:08 lonelyCZ

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 18 '22 06:08 karmada-bot

Have you tested it?

Yes, it works fine in my environment.

lonelyCZ avatar Aug 18 '22 07:08 lonelyCZ

Thanks. /hold cancel

RainbowMango avatar Aug 18 '22 07:08 RainbowMango