karmada icon indicating copy to clipboard operation
karmada copied to clipboard

chart: install together karmada and its component together use `host` installMode

Open calvin0327 opened this issue 2 years ago • 6 comments

What would you like to be added: case: I want install karmada necessary components and search component, I will exec following two commands:

  • Firstly, install karmada with host installMode:
helm install karmada -n karmada-system --create-namespace --dependency-update ./charts/karmada --debug
  • And then install search component with component installMode:
helm install karmada -n karmada-system --create-namespace --dependency-update ./charts/karmada  \
--set installMode=component \ 
--set components={search} --debug

I think it’s not friendly to users, if we combine host and component installMode, and only use a single cmd to completed above operation:

helm install karmada -n karmada-system --create-namespace --dependency-update ./charts/karmada  \
--set components={search}  --debug

Why is this needed: I think It is more convenient to users. please correct me if not.

calvin0327 avatar Jul 30 '22 13:07 calvin0327

@Poor12 @RainbowMango What do you think? We can talk about it together. I dont konw Is there a historical reason with component installMode?

calvin0327 avatar Jul 30 '22 14:07 calvin0327

Karmada-search is mainly a optional components. Users can judge whether to install Karmada-search according to their own needs.

Poor12 avatar Aug 01 '22 01:08 Poor12

Karmada-search is mainly a optional components. Users can judge whether to install Karmada-search according to their own needs.

Yes, you are right. the schedulerEstimator, descheduler and search are all optional components. we can use flag --set components to select components to install. If we are not set the flag that means we don't install them. I mean we don't need to install karmada and component separately.

calvin0327 avatar Aug 01 '22 03:08 calvin0327

We will use karmadactl addons to deploy optional conponents, referring #2134 . Surely we also should be able to select to deploy them by Helm.

lonelyCZ avatar Aug 01 '22 06:08 lonelyCZ

Karmada-search is mainly a optional components. Users can judge whether to install Karmada-search according to their own needs.

Yes, you are right. the schedulerEstimator, descheduler and search are all optional components. we can use flag --set components to select components to install. If we are not set the flag that means we don't install them. I mean we don't need to install karmada and component separately.

Sorry for misunderstanding. I think it's quite useful to provide a way to install together while maintaining the original optional strategy. Are you willing to work on it?

Poor12 avatar Aug 02 '22 03:08 Poor12

@Poor12 ok. /assign

calvin0327 avatar Aug 02 '22 09:08 calvin0327