karmada icon indicating copy to clipboard operation
karmada copied to clipboard

somethings different between charts and artifacts

Open zhixian82 opened this issue 2 years ago • 5 comments

  1. a validate webhook config defined in:

https://github.com/karmada-io/karmada/blob/master/charts/karmada/templates/_karmada_webhook_configuration.tpl#L62

while no such configuration in https://github.com/karmada-io/karmada/blob/master/artifacts/deploy/webhook-configuration.yaml

which one is correct?

zhixian82 avatar Jul 25 '22 09:07 zhixian82

Seems we don't have MutatingWebhookConfiguration for ClusterOverridePolicy, I guess it's a mistake from #1129.

@lonelyCZ can you help to confirm it?

RainbowMango avatar Jul 25 '22 10:07 RainbowMango

/assign {[email protected]}

ligapeng avatar Aug 03 '22 12:08 ligapeng

a validate webhook config defined in: https://github.com/karmada-io/karmada/blob/master/charts/karmada/templates/_karmada_webhook_configuration.tpl#L62

while no such configuration in https://github.com/karmada-io/karmada/blob/master/artifacts/deploy/webhook-configuration.yaml

It seems same. What is different?

https://github.com/karmada-io/karmada/blob/ec84d649a9975435f58f690493e943204f9fbff6/charts/karmada/templates/_karmada_webhook_configuration.tpl#L62

https://github.com/karmada-io/karmada/blob/ec84d649a9975435f58f690493e943204f9fbff6/artifacts/deploy/webhook-configuration.yaml#L122

lonelyCZ avatar Aug 03 '22 12:08 lonelyCZ

Seems we don't have MutatingWebhookConfiguration for ClusterOverridePolicy, I guess it's a mistake from https://github.com/karmada-io/karmada/pull/1129.

I remember that it didn't have mutating operating, so not to add it.

lonelyCZ avatar Aug 03 '22 12:08 lonelyCZ

/assign @ligapeng

ligapeng avatar Aug 04 '22 01:08 ligapeng