karmada
karmada copied to clipboard
improve karmadactl init
What type of PR is this?
/kind feature
What this PR does / why we need it:
make the code more readable
Does this PR introduce a user-facing change?:
NONE
/hold
waiting for #2191 to be merged
/cc @lonelyCZ @prodanlabs
waiting for #2191 to be merged
Thank @carlory , #2191 has been merged. /hold cancel
/LGTM
/cc @lonelyCZ @prodanlabs
@prodanlabs Unfortunately, the e2e testing was failed.
the lgtm
label is removed, could you review it again ?
@lonelyCZ @prodanlabs updated
I will review ASAP.
/assign
Hi @carlory , please rebase this branch and resolve conflicts.
I just tested it that worked fine!
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from lonelycz after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/lgtm
/assign @prodanlabs @RainbowMango
/cc @RainbowMango
Please take a look @RainbowMango @prodanlabs
I can see this PR include two changes:
- rename package
pkg/karmadactl/cmdinit/options
topkg/karmadactl/cmdinit/constants
- move all options to
pkg/karmadactl/cmdinit/kubernetes/options.go
My question is these are the options for pkg/karmadactl/cmdinit
, why put it under kubernetes
?