karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Adopt transform func to save memory

Open dddddai opened this issue 2 years ago • 6 comments

What type of PR is this? /kind feature

What this PR does / why we need it: https://github.com/karmada-io/karmada/pull/1858#issuecomment-1134114741 Now it just removes metadata.ManagedFields since it's large and we never use it

Which issue(s) this PR fixes: Fixes #1866

Special notes for your reviewer: Looking forward to how much memory this can save

Does this PR introduce a user-facing change?:

NONE

dddddai avatar Jun 29 '22 10:06 dddddai

Looking forward to how much memory this can save

Yeah, me too. How to measure it? I've no idea.

RainbowMango avatar Jun 29 '22 12:06 RainbowMango

Since it is only related to informer, maybe we can use benchmark to simulate it.

Poor12 avatar Jun 29 '22 12:06 Poor12

Is there measurement result now?

snowplayfire avatar Jul 16 '22 10:07 snowplayfire

Is there measurement result now?

@dddddai Is there a way that we can measure the improvement?

RainbowMango avatar Jul 18 '22 01:07 RainbowMango

Sorry I'm not very familiar with performance testing

Since it is only related to informer, maybe we can use benchmark to simulate it.

Yeah it would be simple to benchmark the informer cache(with pprof?), but for the whole system, how can we tell how much memory "the informer part" consumes?

dddddai avatar Jul 18 '22 03:07 dddddai

/assign

RainbowMango avatar Sep 01 '22 11:09 RainbowMango

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 16 '22 02:09 karmada-bot

Glad to see it works :)

dddddai avatar Sep 16 '22 02:09 dddddai