karmada
karmada copied to clipboard
Adopt transform func to save memory
What type of PR is this? /kind feature
What this PR does / why we need it:
https://github.com/karmada-io/karmada/pull/1858#issuecomment-1134114741
Now it just removes metadata.ManagedFields
since it's large and we never use it
Which issue(s) this PR fixes: Fixes #1866
Special notes for your reviewer: Looking forward to how much memory this can save
Does this PR introduce a user-facing change?:
NONE
Looking forward to how much memory this can save
Yeah, me too. How to measure it? I've no idea.
Since it is only related to informer, maybe we can use benchmark
to simulate it.
Is there measurement result now?
Is there measurement result now?
@dddddai Is there a way that we can measure the improvement?
Sorry I'm not very familiar with performance testing
Since it is only related to informer, maybe we can use
benchmark
to simulate it.
Yeah it would be simple to benchmark the informer cache(with pprof
?), but for the whole system, how can we tell how much memory "the informer part" consumes?
/assign
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Glad to see it works :)