karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Add metrics_recorder for scheduler framework

Open Poor12 opened this issue 2 years ago • 5 comments

Signed-off-by: Poor12 [email protected]

What type of PR is this? /kind feature

What this PR does / why we need it: Add metrics_recorder for scheduler framework so we can measure the performance of each scheduler plugin.

karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0001"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0002"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0004"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0008"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0016"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0032"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0064"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0128"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0256"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.0512"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.1024"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="0.2048"} 1
karmada_scheduler_framework_extension_point_duration_seconds_bucket{extension_point="Score",result="Success",le="+Inf"} 1
karmada_scheduler_framework_extension_point_duration_seconds_sum{extension_point="Score",result="Success"} 9.411e-06
karmada_scheduler_framework_extension_point_duration_seconds_count{extension_point="Score",result="Success"} 1
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="1e-05"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="1.5000000000000002e-05"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="2.2500000000000005e-05"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="3.375000000000001e-05"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="5.062500000000001e-05"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="7.593750000000002e-05"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.00011390625000000003"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.00017085937500000006"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.0002562890625000001"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.00038443359375000017"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.0005766503906250003"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.0008649755859375004"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.0012974633789062506"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.0019461950683593758"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.0029192926025390638"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.004378938903808595"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.006568408355712893"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.009852612533569338"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.014778918800354007"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="0.02216837820053101"} 3
karmada_scheduler_plugin_execution_duration_seconds_bucket{extension_point="Filter",plugin="APIInstalled",result="Success",le="+Inf"} 3
karmada_scheduler_plugin_execution_duration_seconds_sum{extension_point="Filter",plugin="APIInstalled",result="Success"} 1.546e-06
karmada_scheduler_plugin_execution_duration_seconds_count{extension_point="Filter",plugin="APIInstalled",result="Success"} 3
....

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: None

Poor12 avatar Jun 29 '22 07:06 Poor12

Please help to figure out the failing case.

RainbowMango avatar Jun 29 '22 12:06 RainbowMango

e2e may be solved after #2095 is merged. need retest.

Poor12 avatar Jun 30 '22 12:06 Poor12

e2e may be solved after #2095 is merged. need retest.

We can rebase the master branch and push it again.

XiShanYongYe-Chang avatar Jun 30 '22 12:06 XiShanYongYe-Chang

/cc @RainbowMango

Poor12 avatar Oct 20 '22 08:10 Poor12

/assign I'll reserve time for the metrics thing next week.

RainbowMango avatar Oct 20 '22 09:10 RainbowMango

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 24 '22 03:10 karmada-bot