karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Performance improve for karmada-controller-manager

Open Poor12 opened this issue 2 years ago • 2 comments

Signed-off-by: Poor12 [email protected]

What type of PR is this? /kind feature

What this PR does / why we need it: As is talked in #1858,when member cluster is large(3k nodes, 10w pods), karmada-controller-manager is easy to be OOMkilled and retry to sync nodes and pods again and again.

Based on #2008, I tested the two clusters with 100 nodes and almost 300 pods. We can easily see that in cluster status controllers, list nodes and pods periodicly cost a lot when the cluster is large(a lot of unmarshal works) according to the frame graph. 1

So I modified the mechanism from full amount list to watch based on event to make the memory increase more stable.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: None

Poor12 avatar Jun 20 '22 07:06 Poor12

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign rainbowmango after the PR has been reviewed. You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jun 20 '22 07:06 karmada-bot

cc @RainbowMango

Poor12 avatar Jun 20 '22 07:06 Poor12