karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[Proposal]Provides metrics to improve Karmada observability

Open Poor12 opened this issue 2 years ago • 9 comments

Signed-off-by: Poor12 [email protected]

What type of PR is this? /kind feature

What this PR does / why we need it: Provides metrics to reflect the status of Karmada resources and performance of Karmada components

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: None

Poor12 avatar Jun 06 '22 07:06 Poor12

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jun 06 '22 07:06 karmada-bot

Rich metrics are very needed. @RainbowMango

But for karmada, it is difficult to get duation metric from detecting resources to sync to member clusters. What can we try to solve it?

snowplayfire avatar Aug 17 '22 13:08 snowplayfire

Yes. I agree. But I'm not sure if this can be included in v1.13.

RainbowMango avatar Aug 18 '22 00:08 RainbowMango

We need this feature urgently. When can we start to implement it? @Poor12 @RainbowMango

chaunceyjiang avatar Sep 15 '22 07:09 chaunceyjiang

Then, please help to review this proposal. I'll look at it later.

RainbowMango avatar Sep 15 '22 08:09 RainbowMango

We need this feature urgently. When can we start to implement it? @Poor12 @RainbowMango

Hi @chaunceyjiang,this proposal is more like a draft. Can you tell me which indicator of Karmada do you pay more attention to, we can discuss it together.

Poor12 avatar Sep 15 '22 08:09 Poor12

/cc @SAMZONG @wawa0210

chaunceyjiang avatar Sep 16 '22 03:09 chaunceyjiang

@chaunceyjiang: GitHub didn't allow me to request PR reviews from the following users: SAMZONG.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @SAMZONG @wawa0210

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karmada-bot avatar Sep 16 '22 03:09 karmada-bot

I'm unsure if a proposal is appropriate for metrics, as we may continually introduce new metrics. It's impossible for this proposal to hold all necessary metrics.

RainbowMango avatar Sep 19 '22 03:09 RainbowMango

We will continue to track the improvement of observability through issues and documents.

Poor12 avatar Sep 27 '22 12:09 Poor12