dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Feature/turborepo

Open warjiang opened this issue 1 year ago • 2 comments

What type of PR is this? /kind feature

What this PR does / why we need it:

  1. implement @karmada/terminal and corresponding addon(zmodem and overlay addon)
  2. introduce turborepo, which is very useful to solve the dependency tree under the ui folder
  3. introduce changeset to gen changelog for ui components under the ui/packages folder

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. implement @karmada/terminal and corresponding addon(zmodem and overlay addon)
2. introduce turborepo and changeset tools

warjiang avatar Jul 10 '24 04:07 warjiang

/assign @samzong

warjiang avatar Jul 10 '24 04:07 warjiang

@warjiang Is this ready to move forward? Would you like to rebase, since this PR has been waiting for a while, I don't know if it still passes the CI tests.

RainbowMango avatar Aug 19 '24 07:08 RainbowMango

@warjiang Is this ready to move forward? Would you like to rebase, since this PR has been waiting for a while, I don't know if it still passes the CI tests.

I'll rebase and recheck this PR locally. Need more time~

warjiang avatar Aug 19 '24 08:08 warjiang

OK. no rush, take your time, just assign it to me once you are ready.

RainbowMango avatar Aug 19 '24 08:08 RainbowMango

@RainbowMango I've rebase the code and re-check the build ci, plz check it again.

warjiang avatar Aug 21 '24 03:08 warjiang

@RainbowMango I've rebase the code and re-check the build ci, plz check it again.

the PR is still large, do I need to split it into multi PRs. Some background is that the feature of this PR(turborepo and ui components) can work standalone.

warjiang avatar Aug 21 '24 03:08 warjiang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 26 '24 02:08 karmada-bot