karmada-io
Added DataTable Component
What type of PR is this? /kind feature
What this PR does / why we need it: The PR includes a reusable Table component to be used on different pages with different types of data. This is the first iteration of the component. It will be modified further with API integration and required functionalities working. It is static and currently implementing this Figma Design ( Overview Page - iteration 7 frame ).
Which issue(s) this PR fixes: It's a general component useful for different pages of the entire application.
Special notes for your reviewer: @RainbowMango I'm attaching the screenshot of the developed UI, which was taken by using the component on a new page just for testing. Although, it is not used in any of the pages currently. So, the PR is just having its implementation.
Does this PR introduce a user-facing change?:
NONE
Signed-off-by: @ShwetKhatri2001
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @ShwetKhatri2001! It looks like this is your first PR to karmada-io/dashboard 🎉
Seems it's a static page now, I can't tell if works as expected, I guess we'd better build a real page with it.
I need some resources to understand the API response. So that I can make the component dynamic with the actual data.
@ShwetKhatri2001 Check out this file. I'm using this one as API design spec. https://github.com/karmada-io/karmada/blob/master/api/openapi-spec/swagger.json
@ada2468 Thanks for the help, but we will have different types of data passed to this component and the pages where the component is going to be used are not developed/merged yet. so, the component can't be completely dynamic or finalized currently according to me. @RainbowMango what's your thought on this?
/close Thank you for your effort on this, we are currently working with another approach.
@RainbowMango: Closed this PR.
In response to this:
/close Thank you for your effort on this, we are currently working with another approach.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.